cron provider does not support month names and weekday names

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 10.14.0
  • Component/s: None
  • Labels:
    None

Description

from crontab(5):

month 1-12 (or names, see below)
day of week 0-7 (0 or 7 is Sun, or use names)

the regex in lib/chef/provider/cron.rb for matching CRON_PATTERN lines does not seem to take this into account, which can lead to unrelated jobs being eaten by a grue^Wchef.

  1. Text File
    CHEF-3178-cron_regex.patch
    21/Jun/12 8:54 PM
    0.6 kB
    Xabier de Zuazo [Onddo Labs]
  2. Text File
    CHEF-3178-cron_regex-fixed.patch
    21/Jun/12 11:29 PM
    0.7 kB
    Xabier de Zuazo [Onddo Labs]

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. CHEF-939 Non-integer cron hour causes cron entry to be matched incorrectly

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Xabier de Zuazo [Onddo Labs] added a comment -

The following regex should fix the problem:

CRON_PATTERN = /\A([-0-9*,\/]+)\s([-0-9*,\/]+)\s([-0-9*,\/]+)\s([-0-9*,\/]+|[a-zA-Z]{3})\s([-0-9*,\/]+|[a-zA-Z]{3})\s(.*)/

I will attach a simple patch.

Show
Xabier de Zuazo [Onddo Labs] added a comment - The following regex should fix the problem: CRON_PATTERN = /\A([-0-9*,\/]+)\s([-0-9*,\/]+)\s([-0-9*,\/]+)\s([-0-9*,\/]+|[a-zA-Z]{3})\s([-0-9*,\/]+|[a-zA-Z]{3})\s(.*)/ I will attach a simple patch.
Hide
Permalink
Xabier de Zuazo [Onddo Labs] added a comment -

CRON_PATTERN regex fix for month and weekday names.

Show
Xabier de Zuazo [Onddo Labs] added a comment - CRON_PATTERN regex fix for month and weekday names.
Hide
Permalink
Xabier de Zuazo [Onddo Labs] added a comment -

CRON_PATTERN regex fix for month and weekday names (old regex removed).

Show
Xabier de Zuazo [Onddo Labs] added a comment - CRON_PATTERN regex fix for month and weekday names (old regex removed).
Hide
Permalink
Xabier de Zuazo [Onddo Labs] added a comment -

Excuse me, I forgot to remove the old "regex". I attached a fixed patch.

Show
Xabier de Zuazo [Onddo Labs] added a comment - Excuse me, I forgot to remove the old "regex". I attached a fixed patch.
Hide
Permalink
Xabier de Zuazo [Onddo Labs] added a comment -

"CHEF-3178-cron_regex-fixed.patch" solves the regex problem.

Show
Xabier de Zuazo [Onddo Labs] added a comment - " CHEF-3178 -cron_regex-fixed.patch" solves the regex problem.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

This is good, but we should have a regression test, especially because we're dealing with a regular expression here. Could you write one please?

Show
Bryan McLellan [Opscode] added a comment - This is good, but we should have a regression test, especially because we're dealing with a regular expression here. Could you write one please?
Hide
Permalink
Xabier de Zuazo [Onddo Labs] added a comment -

Pull request that fixes this cron problem, including a Regression Test: https://github.com/opscode/chef/pull/332

Show
Xabier de Zuazo [Onddo Labs] added a comment - Pull request that fixes this cron problem, including a Regression Test: https://github.com/opscode/chef/pull/332
Hide
Permalink
Xabier de Zuazo [Onddo Labs] added a comment -

Github pull request added with the fix and a Regression Test.

Show
Xabier de Zuazo [Onddo Labs] added a comment - Github pull request added with the fix and a Regression Test.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Thanks Xabier, marked for merge.

Show
Bryan McLellan [Opscode] added a comment - Thanks Xabier, marked for merge.
Hide
Permalink
KC Braunschweig added a comment -

See also: CHEF-939

Show
KC Braunschweig added a comment - See also: CHEF-939
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to master. Thanks Xabier.

Show
Bryan McLellan [Opscode] added a comment - Merged to master. Thanks Xabier.

People

  • Assignee:
    Xabier de Zuazo [Onddo Labs]
    Reporter:
    Tollef Fog Heen
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: