[regression] file(...).owner and file(...).mode returns nil instead of expected integer value

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.10.10, 10.12.0
  • Fix Version/s: 10.14.0
  • Component/s: Chef Client
  • Labels:

Description

A regression was introduced, according to acrmp, at commit 4eba6949adc5dbabe5b054d42ecebb3fdeffc987 (version 0.10.10 of chef).

(https://github.com/opscode/chef/commit/4eba6949adc5dbabe5b054d42ecebb3fdeffc987)

The symptoms are that the following code would return 'nil' instead the correct value. For example:

p file("/etc/fstab").owner

or

p file("/etc/fstab").mode

Instead of the values of '0' or '420' being returned as expected, you will get a value of 'nil'.

This was found when writing tests using minitest-chef-handler against Chef 0.10.10 and 0.10.12. This is a regression post 0.10.8 (where the expected return values are correct).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Crump added a comment -

See Leif's original issue on the minitest-chef-handler project:
https://github.com/calavera/minitest-chef-handler/issues/23

I commented there:

It looks like #load_current_resource on the file resource no longer populates the owner and mode with the state of an existing file.

This is a change that will not have affected normal end users of Chef - it is an issue for minitest-chef-handler because it relies on the behaviour of #load_current_resource being consistent with earlier versions of Chef.

Show
Andrew Crump added a comment - See Leif's original issue on the minitest-chef-handler project: https://github.com/calavera/minitest-chef-handler/issues/23 I commented there: It looks like #load_current_resource on the file resource no longer populates the owner and mode with the state of an existing file. This is a change that will not have affected normal end users of Chef - it is an issue for minitest-chef-handler because it relies on the behaviour of #load_current_resource being consistent with earlier versions of Chef.
Hide
Permalink
Leif Madsen added a comment -

I've been looking at the changes, and I can't seem to determine if the ability to look up a files owner and group has simply been moved to a different provider/resource, or if that functionality has simply been dropped by the recent changes to the file resource and provider.

I know this is a support issue potentially, but if it could be pointed out where the functionality has been moved to, then this could be closed and I could create a pull request for minitest-chef-handler to use the new methods.

If this ability has been removed, then this issue essentially is a regression of functionality that needs to be added back in.

Thanks!

Show
Leif Madsen added a comment - I've been looking at the changes, and I can't seem to determine if the ability to look up a files owner and group has simply been moved to a different provider/resource, or if that functionality has simply been dropped by the recent changes to the file resource and provider. I know this is a support issue potentially, but if it could be pointed out where the functionality has been moved to, then this could be closed and I could create a pull request for minitest-chef-handler to use the new methods. If this ability has been removed, then this issue essentially is a regression of functionality that needs to be added back in. Thanks!
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged. Fixed in 3ff8397 + d2075e3

https://github.com/opscode/chef/pull/361

Show
Bryan McLellan [Opscode] added a comment - Merged. Fixed in 3ff8397 + d2075e3 https://github.com/opscode/chef/pull/361

People

  • Assignee:
    Unassigned
    Reporter:
    Leif Madsen
Vote (2)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: