Expanding '~/Library/LaunchAgents' fails resolving HOME when running chef-client as root

Details

Description

I'm extending the chef-client::service recipe to register chef-client as a Mac OS X daemon using the recently introduced Mac OS X service provider to Chef (since 0.10.10). One can checkout my work via COOK-1379.

However, when running chef-client as root, I always get the following stack trace, resulting a chef client run with an error. The service however is successfully registered.

[2012-06-25T12:12:02+02:00] INFO: Processing service[chef-client] action start (chef-client::service line 244)
[2012-06-25T12:12:02+02:00] ERROR: service[chef-client] (chef-client::service line 244) has had an error
[2012-06-25T12:12:02+02:00] ERROR: service[chef-client] (/var/chef/cache/cookbooks/chef-client/recipes/service.rb:244:in `from_file') had an error:
service[chef-client] (chef-client::service line 244) had an error: ArgumentError: couldn't find HOME environment -- expanding `~/Library/LaunchAgents'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/provider/service/macosx.rb:111:in `expand_path'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/provider/service/macosx.rb:111:in `find_service_plist'
/Library/Ruby/Gems/1.8/gems/erubis-2.7.0/lib/erubis/evaluator.rb:73:in `inject'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/provider/service/macosx.rb:110:in `each'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/provider/service/macosx.rb:110:in `inject'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/provider/service/macosx.rb:110:in `find_service_plist'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/provider/service/macosx.rb:36:in `load_current_resource'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/resource.rb:453:in `run_action'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/runner.rb:49:in `run_action'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/runner.rb:85:in `converge'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/runner.rb:85:in `each'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/runner.rb:85:in `converge'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/resource_collection.rb:94:in `execute_each_resource'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/resource_collection/stepable_iterator.rb:116:in `call'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/resource_collection/stepable_iterator.rb:116:in `call_iterator_block'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/resource_collection/stepable_iterator.rb:85:in `step'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/resource_collection/stepable_iterator.rb:104:in `iterate'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/resource_collection/stepable_iterator.rb:55:in `each_with_index'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/resource_collection.rb:92:in `execute_each_resource'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/runner.rb:80:in `converge'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/client.rb:330:in `converge'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/client.rb:163:in `run'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/application/client.rb:254:in `run_application'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/application/client.rb:241:in `loop'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/application/client.rb:241:in `run_application'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/../lib/chef/application.rb:70:in `run'
/Library/Ruby/Gems/1.8/gems/chef-10.12.0/bin/chef-client:26
/usr/bin/chef-client:19:in `load'
/usr/bin/chef-client:19
[2012-06-25T12:12:02+02:00] ERROR: Running exception handlers
[2012-06-25T12:12:02+02:00] FATAL: Saving node information to /var/chef/cache/failed-run-data.json
[2012-06-25T12:12:02+02:00] ERROR: Exception handlers complete

Issue Links

relates to

New Feature - A new feature of the product, which has yet to be developed. CHEF-1700 Service Provider for Mac OS X

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ringo De Smet added a comment -

https://github.com/opscode/chef/pull/325

Show
Ringo De Smet added a comment - https://github.com/opscode/chef/pull/325
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

We can't keep adding to the constant every time a new class object is created. This patch should be in the class itself, provided that it will evaluate everywhere (e.g. Windows).

There should also be tests proving the results, which will be particularly useful testing against other platforms.

Show
Bryan McLellan [Opscode] added a comment - We can't keep adding to the constant every time a new class object is created. This patch should be in the class itself, provided that it will evaluate everywhere (e.g. Windows). There should also be tests proving the results, which will be particularly useful testing against other platforms.
Hide
Permalink
Ringo De Smet added a comment -

Bryan, I lack detailed Ruby knowledge to implement what you suggest. On top of that, I do not have any other platform besides Mac & Ubuntu to test on. Can this be taken up by someone at Opscode?

Show
Ringo De Smet added a comment - Bryan, I lack detailed Ruby knowledge to implement what you suggest. On top of that, I do not have any other platform besides Mac & Ubuntu to test on. Can this be taken up by someone at Opscode?
Hide
Permalink
Daniel DeLeo added a comment -

We can help you along.

So, remember that class definitions are executable code, so you can do, e.g.,

class Foo
  if some_test
    CONST << "another value"
  end
end

And it will only be executed once, when the file is loaded.

We've checked and Process.uid always returns 0 on windows, which is fine.

Show
Daniel DeLeo added a comment - We can help you along. So, remember that class definitions are executable code, so you can do, e.g., class Foo if some_test CONST << "another value" end end And it will only be executed once, when the file is loaded. We've checked and Process.uid always returns 0 on windows, which is fine.
Hide
Permalink
Igor Afonov added a comment -

(I think I should jumped to this ticket earlier but nevertheless)

While I was developing OS X provider I've tested it on my developer's machine and laptop and haven't seen such problems. Today I've tested it again and wasn't able to reproduce the issue. Could you please give more information about your environment? It seems that you don't have `$HOME` set in root env.

Here is quick test:

local➜  ~  sudo su  
sh-3.2# ruby -v
ruby 1.8.7 (2010-01-10 patchlevel 249) [i686-darwin11.0.0]
sh-3.2# sw_vers
ProductName:	Mac OS X
ProductVersion:	10.7
BuildVersion:	11A511
sh-3.2# echo $HOME 
/var/root
sh-3.2# irb
(main):001:0> File.expand_path "~/Library/LaunchAgents"
=> "/var/root/Library/LaunchAgents"

While it is ease for me to make changes to the code (and I'd do it) I want to find out the original cause of the issue.

Thanks!

Show
Igor Afonov added a comment - (I think I should jumped to this ticket earlier but nevertheless) While I was developing OS X provider I've tested it on my developer's machine and laptop and haven't seen such problems. Today I've tested it again and wasn't able to reproduce the issue. Could you please give more information about your environment? It seems that you don't have `$HOME` set in root env. Here is quick test: local➜ ~ sudo su sh-3.2# ruby -v ruby 1.8.7 (2010-01-10 patchlevel 249) [i686-darwin11.0.0] sh-3.2# sw_vers ProductName: Mac OS X ProductVersion: 10.7 BuildVersion: 11A511 sh-3.2# echo $HOME / var /root sh-3.2# irb (main):001:0> File.expand_path "~/Library/LaunchAgents" => "/ var /root/Library/LaunchAgents" While it is ease for me to make changes to the code (and I'd do it) I want to find out the original cause of the issue. Thanks!
Hide
Permalink
Ringo De Smet added a comment -

The problem lies with the way launchd starts chef-client. Below is a small program to reproduce the exception:

/usr/bin/chef-test-3237
#!/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby
#
# This file was generated by RubyGems.
#
# The application 'chef' is installed as part of a gem, and
# this file is here to facilitate running it.
#

require 'logger'

logger = Logger.new('/var/log/chef-test.log')

begin
  expanded_path = File.expand_path('~/Library/LaunchAgents')
  logger.info("expanded path = #{expanded_path}")
rescue Exception => e
  logger.error(e)
end

When run from the shell as root, this is the output in the log file:

I, [2012-07-12T11:43:18.484810 #16386]  INFO -- : expanded path = /var/root/Library/LaunchAgents

Now register this application as a launchd daemon using this plist:

/Library/LaunchDaemons/com.opscode.chef-test.plist
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">

<dict>
  <key>Label</key>
  <string>com.opscode.chef-test</string>
  <key>Program</key>
  <string>/usr/bin/chef-test-3237</string>
  <key>StartInterval</key>
  <integer>60</integer>
  <key>RunAtLoad</key>
  <true/>
  <key>UserName</key>
  <string>root</string>
</dict>

</plist>

And you get this output every 60 seconds in the log file:

E, [2012-07-12T11:44:26.214259 #16405] ERROR -- : couldn't find HOME environment -- expanding `~/Library/LaunchAgents' (ArgumentError)
/usr/bin/chef-test-3237:14:in `expand_path'
/usr/bin/chef-test-3237:14

And it seems I'm not the only one bitten by this:
http://www.skrinakcreative.com/wp/2010/08/lingon-launchd-and-updating-my-macports-installation/

Show
Ringo De Smet added a comment - The problem lies with the way launchd starts chef-client. Below is a small program to reproduce the exception: /usr/bin/chef-test-3237 #!/ System /Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby # # This file was generated by RubyGems. # # The application 'chef' is installed as part of a gem, and # this file is here to facilitate running it. # require 'logger' logger = Logger. new ('/ var /log/chef-test.log') begin expanded_path = File.expand_path('~/Library/LaunchAgents') logger.info( "expanded path = #{expanded_path}" ) rescue Exception => e logger.error(e) end When run from the shell as root, this is the output in the log file: I, [2012-07-12T11:43:18.484810 #16386] INFO -- : expanded path = / var /root/Library/LaunchAgents Now register this application as a launchd daemon using this plist: /Library/LaunchDaemons/com.opscode.chef-test.plist <?xml version= "1.0" encoding= "UTF-8" ?> <!DOCTYPE plist PUBLIC "- //Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd" > <plist version= "1.0" > <dict> <key>Label</key> <string>com.opscode.chef-test</string> <key>Program</key> <string>/usr/bin/chef-test-3237</string> <key>StartInterval</key> <integer>60</integer> <key>RunAtLoad</key> < true /> <key>UserName</key> <string>root</string> </dict> </plist> And you get this output every 60 seconds in the log file: E, [2012-07-12T11:44:26.214259 #16405] ERROR -- : couldn't find HOME environment -- expanding `~/Library/LaunchAgents' (ArgumentError) /usr/bin/chef-test-3237:14:in `expand_path' /usr/bin/chef-test-3237:14 And it seems I'm not the only one bitten by this: http://www.skrinakcreative.com/wp/2010/08/lingon-launchd-and-updating-my-macports-installation/
Hide
Permalink
Jeffrey Damick added a comment - - edited

i see a similar issue on ubuntu 12.04, maybe this isnt just mac specific..

interestingly puppet has seen the same issue: http://projects.puppetlabs.com/issues/16137

Show
Jeffrey Damick added a comment - - edited i see a similar issue on ubuntu 12.04, maybe this isnt just mac specific.. interestingly puppet has seen the same issue: http://projects.puppetlabs.com/issues/16137
Hide
Permalink
Ringo De Smet added a comment -

This is how they fixed it in Puppet:
https://github.com/puppetlabs/puppet/commit/3f62908494d6194bf1bba9c2fe5260570a7f7e9c#L1L66

Show
Ringo De Smet added a comment - This is how they fixed it in Puppet: https://github.com/puppetlabs/puppet/commit/3f62908494d6194bf1bba9c2fe5260570a7f7e9c#L1L66
Hide
Permalink
Ringo De Smet added a comment - - edited

The user specific LaunchAgents folder (~/Library/LaunchAgents) is only added when not running as root. The last change only adds it when the class is loaded instead of in the constructor of the provider.

https://github.com/opscode/chef/pull/544

Below is the Chef log on my Mac before and after the fix applied:

[2012-12-14T09:47:28+01:00] INFO: *** Chef 10.16.2 ***
[2012-12-14T09:47:32+01:00] INFO: Run List is [role[managed]]
[2012-12-14T09:47:32+01:00] INFO: Run List expands to [chef-client::service]
[2012-12-14T09:47:33+01:00] INFO: Starting Chef Run for atrisobook
[2012-12-14T09:47:33+01:00] INFO: Running start handlers
[2012-12-14T09:47:33+01:00] INFO: Start handlers complete.
[2012-12-14T09:47:34+01:00] INFO: Loading cookbooks [chef-client]
[2012-12-14T09:47:35+01:00] INFO: Processing directory[/var/run] action create (chef-client::service line 45)
[2012-12-14T09:47:35+01:00] INFO: Processing directory[/Library/Caches/Chef] action create (chef-client::service line 45)
[2012-12-14T09:47:35+01:00] INFO: Processing directory[/Library/Caches/Chef/Backup] action create (chef-client::service line 45)
[2012-12-14T09:47:35+01:00] INFO: Processing directory[/Library/Logs/Chef] action create (chef-client::service line 45)
[2012-12-14T09:47:35+01:00] INFO: Processing template[/Library/LaunchDaemons/com.opscode.chef-client.plist] action create (chef-client::service line 246)
[2012-12-14T09:47:35+01:00] INFO: Processing service[chef-client] action start (chef-client::service line 251)
[2012-12-14T09:47:35+01:00] ERROR: Running exception handlers
[2012-12-14T09:47:35+01:00] FATAL: Saving node information to /var/chef/cache/failed-run-data.json
[2012-12-14T09:47:35+01:00] ERROR: Exception handlers complete
[2012-12-14T09:47:35+01:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
[2012-12-14T09:47:35+01:00] FATAL: ArgumentError: service[chef-client] (chef-client::service line 251) had an error: ArgumentError: couldn't find HOME environment -- expanding `~'
[2012-12-14T10:17:33+01:00] INFO: *** Chef 10.16.2 ***
[2012-12-14T10:17:43+01:00] INFO: Run List is [role[managed]]
[2012-12-14T10:17:43+01:00] INFO: Run List expands to [chef-client::service]
[2012-12-14T10:17:44+01:00] INFO: Chef server generated run history id: 7d6d68d9f8d7e60126bc2cfa410d369d
[2012-12-14T10:17:44+01:00] INFO: Starting Chef Run for atrisobook
[2012-12-14T10:17:44+01:00] INFO: Running start handlers
[2012-12-14T10:17:44+01:00] INFO: Start handlers complete.
[2012-12-14T10:17:45+01:00] INFO: Loading cookbooks [chef-client]
[2012-12-14T10:17:46+01:00] INFO: Processing directory[/var/run] action create (chef-client::service line 45)
[2012-12-14T10:17:46+01:00] INFO: Processing directory[/Library/Caches/Chef] action create (chef-client::service line 45)
[2012-12-14T10:17:46+01:00] INFO: Processing directory[/Library/Caches/Chef/Backup] action create (chef-client::service line 45)
[2012-12-14T10:17:46+01:00] INFO: Processing directory[/Library/Logs/Chef] action create (chef-client::service line 45)
[2012-12-14T10:17:46+01:00] INFO: Processing template[/Library/LaunchDaemons/com.opscode.chef-client.plist] action create (chef-client::service line 246)
[2012-12-14T10:17:46+01:00] INFO: Processing service[chef-client] action start (chef-client::service line 251)
[2012-12-14T10:17:47+01:00] INFO: Chef Run complete in 3.477388 seconds
[2012-12-14T10:17:48+01:00] INFO: Running report handlers
[2012-12-14T10:17:48+01:00] INFO: Report handlers complete
[2012-12-14T10:17:48+01:00] INFO: Sending resource update report (run-id: 7d6d68d9f8d7e60126bc2cfa410d369d)
[2012-12-14T10:17:48+01:00] INFO: run_data_summary: {"action"=>"end", "resources"=>[], "status"=>"success", "run_list"=>"[\"role[managed]\"]", "total_res_count"=>"6", "data"=>{}, "updated_res_count"=>"0", "post_size"=>"112"}
Show
Ringo De Smet added a comment - - edited The user specific LaunchAgents folder ( ~/Library/LaunchAgents ) is only added when not running as root . The last change only adds it when the class is loaded instead of in the constructor of the provider. https://github.com/opscode/chef/pull/544 Below is the Chef log on my Mac before and after the fix applied: [2012-12-14T09:47:28+01:00] INFO: *** Chef 10.16.2 *** [2012-12-14T09:47:32+01:00] INFO: Run List is [role[managed]] [2012-12-14T09:47:32+01:00] INFO: Run List expands to [chef-client::service] [2012-12-14T09:47:33+01:00] INFO: Starting Chef Run for atrisobook [2012-12-14T09:47:33+01:00] INFO: Running start handlers [2012-12-14T09:47:33+01:00] INFO: Start handlers complete. [2012-12-14T09:47:34+01:00] INFO: Loading cookbooks [chef-client] [2012-12-14T09:47:35+01:00] INFO: Processing directory[/var/run] action create (chef-client::service line 45) [2012-12-14T09:47:35+01:00] INFO: Processing directory[/Library/Caches/Chef] action create (chef-client::service line 45) [2012-12-14T09:47:35+01:00] INFO: Processing directory[/Library/Caches/Chef/Backup] action create (chef-client::service line 45) [2012-12-14T09:47:35+01:00] INFO: Processing directory[/Library/Logs/Chef] action create (chef-client::service line 45) [2012-12-14T09:47:35+01:00] INFO: Processing template[/Library/LaunchDaemons/com.opscode.chef-client.plist] action create (chef-client::service line 246) [2012-12-14T09:47:35+01:00] INFO: Processing service[chef-client] action start (chef-client::service line 251) [2012-12-14T09:47:35+01:00] ERROR: Running exception handlers [2012-12-14T09:47:35+01:00] FATAL: Saving node information to /var/chef/cache/failed-run-data.json [2012-12-14T09:47:35+01:00] ERROR: Exception handlers complete [2012-12-14T09:47:35+01:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out [2012-12-14T09:47:35+01:00] FATAL: ArgumentError: service[chef-client] (chef-client::service line 251) had an error: ArgumentError: couldn't find HOME environment -- expanding `~' [2012-12-14T10:17:33+01:00] INFO: *** Chef 10.16.2 *** [2012-12-14T10:17:43+01:00] INFO: Run List is [role[managed]] [2012-12-14T10:17:43+01:00] INFO: Run List expands to [chef-client::service] [2012-12-14T10:17:44+01:00] INFO: Chef server generated run history id: 7d6d68d9f8d7e60126bc2cfa410d369d [2012-12-14T10:17:44+01:00] INFO: Starting Chef Run for atrisobook [2012-12-14T10:17:44+01:00] INFO: Running start handlers [2012-12-14T10:17:44+01:00] INFO: Start handlers complete. [2012-12-14T10:17:45+01:00] INFO: Loading cookbooks [chef-client] [2012-12-14T10:17:46+01:00] INFO: Processing directory[/var/run] action create (chef-client::service line 45) [2012-12-14T10:17:46+01:00] INFO: Processing directory[/Library/Caches/Chef] action create (chef-client::service line 45) [2012-12-14T10:17:46+01:00] INFO: Processing directory[/Library/Caches/Chef/Backup] action create (chef-client::service line 45) [2012-12-14T10:17:46+01:00] INFO: Processing directory[/Library/Logs/Chef] action create (chef-client::service line 45) [2012-12-14T10:17:46+01:00] INFO: Processing template[/Library/LaunchDaemons/com.opscode.chef-client.plist] action create (chef-client::service line 246) [2012-12-14T10:17:46+01:00] INFO: Processing service[chef-client] action start (chef-client::service line 251) [2012-12-14T10:17:47+01:00] INFO: Chef Run complete in 3.477388 seconds [2012-12-14T10:17:48+01:00] INFO: Running report handlers [2012-12-14T10:17:48+01:00] INFO: Report handlers complete [2012-12-14T10:17:48+01:00] INFO: Sending resource update report (run-id: 7d6d68d9f8d7e60126bc2cfa410d369d) [2012-12-14T10:17:48+01:00] INFO: run_data_summary: {"action"=>"end", "resources"=>[], "status"=>"success", "run_list"=>"[\"role[managed]\"]", "total_res_count"=>"6", "data"=>{}, "updated_res_count"=>"0", "post_size"=>"112"}
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

It seems like the issue is that the HOME environment variable doesn't exist, not that you're root. Shouldn't we be testing for that instead? What if a user lacks a HOME variable for some reason?

Also, please include a regression test.

Show
Bryan McLellan [Opscode] added a comment - It seems like the issue is that the HOME environment variable doesn't exist, not that you're root. Shouldn't we be testing for that instead? What if a user lacks a HOME variable for some reason? Also, please include a regression test.
Hide
Permalink
Doc Walker added a comment -

I resolved this by doing the following:

$ sudo launchctl
launchd% getenv HOME

launchd% setenv HOME /var/root
launchd% getenv HOME
/var/root

Credit goes to http://superuser.com/questions/481819/editing-the-etc-launchd-conf-file-in-os-x.

Show
Doc Walker added a comment - I resolved this by doing the following: $ sudo launchctl launchd% getenv HOME launchd% setenv HOME / var /root launchd% getenv HOME / var /root Credit goes to http://superuser.com/questions/481819/editing-the-etc-launchd-conf-file-in-os-x .
Hide
Permalink
Doc Walker added a comment -

The recipe might be modified to check result of

launchctl getenv HOME

and use

launchctl setenv HOME /var/root

if blank.

Show
Doc Walker added a comment - The recipe might be modified to check result of launchctl getenv HOME and use launchctl setenv HOME / var /root if blank.
Hide
Permalink
Daniel DeLeo added a comment -

Changing fix version, as this didn't make it in for 10.18.0 RC.

Show
Daniel DeLeo added a comment - Changing fix version, as this didn't make it in for 10.18.0 RC.
Hide
Permalink
Ringo De Smet added a comment -

Help asked on chef-dev mailing list for code review and RSpec test.

Show
Ringo De Smet added a comment - Help asked on chef-dev mailing list for code review and RSpec test.
Hide
Permalink
Igor Afonov added a comment -

Hi, I have submitted a pull request with fix - https://github.com/opscode/chef/pull/624

Show
Igor Afonov added a comment - Hi, I have submitted a pull request with fix - https://github.com/opscode/chef/pull/624
Hide
Permalink
Igor Afonov added a comment -

I've moved ticket to 'Fix Provided' not sure that it is correct move. Should I do anything else to get it reviewed and merged? Thanks!

Show
Igor Afonov added a comment - I've moved ticket to 'Fix Provided' not sure that it is correct move . Should I do anything else to get it reviewed and merged? Thanks!
Hide
Permalink
Ringo De Smet added a comment -

Bryan, you set the fix version to None. What do you mean by this? Will this ever get integrated in Chef client?

Show
Ringo De Smet added a comment - Bryan, you set the fix version to None. What do you mean by this? Will this ever get integrated in Chef client?
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

The fix version really shouldn't be set until it is merged. Yesterday we had to make an quick release with limited testing due to another gem library's changes, so we couldn't release a bunch of other patches.

It will get released after the next regular merge pass.

Show
Bryan McLellan [Opscode] added a comment - The fix version really shouldn't be set until it is merged. Yesterday we had to make an quick release with limited testing due to another gem library's changes, so we couldn't release a bunch of other patches. It will get released after the next regular merge pass.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Igor:

Comments on PR 624 (also on the PR):

  • Don't need locations.tap
  • Don't need to specify Macosx
  • Don't mangle ENV in the tests
  • Also should stub ENV['HOME'] in the test that depends on it being set.
Show
Bryan McLellan [Opscode] added a comment - Igor: Comments on PR 624 (also on the PR): Don't need locations.tap Don't need to specify Macosx Don't mangle ENV in the tests Also should stub ENV ['HOME'] in the test that depends on it being set.
Hide
Permalink
Ringo De Smet added a comment -

Bryan,

I created a new pull request out of my own repository. I rebased Igor's changes and incorporated your review comments on his work.

Ringo

Show
Ringo De Smet added a comment - Bryan, I created a new pull request out of my own repository. I rebased Igor's changes and incorporated your review comments on his work. Ringo
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

https://github.com/opscode/chef/pull/767/files?w=1

Show
Bryan McLellan [Opscode] added a comment - https://github.com/opscode/chef/pull/767/files?w=1
Hide
Permalink
Ringo De Smet added a comment -

I updated the pull request with your last review comments. The code now reads

#{ENV['HOME']}/Library/LaunchAgents
Show
Ringo De Smet added a comment - I updated the pull request with your last review comments. The code now reads #{ENV['HOME']}/Library/LaunchAgents
Hide
Permalink
Ringo De Smet added a comment -

Any idea when this will be merged and released?

Show
Ringo De Smet added a comment - Any idea when this will be merged and released?
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to master, expecting 11.6.0 in mid-July.

Show
Bryan McLellan [Opscode] added a comment - Merged to master, expecting 11.6.0 in mid-July.

People

  • Assignee:
    Ringo De Smet
    Reporter:
    Ringo De Smet
Vote (2)
Watch (6)

Dates

  • Created:
    Updated:
    Resolved: