usermod group provider does not work on solaris2 platform

Details

Description

Adding users to a group does not work on Solaris 5.10 (solaris2). The -G flag is missing. Also, the error message should be changed to make it clear that you need to set append true in the group for this to work.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martha Greenberg added a comment -

Fixed in git://github.com/wix/chef.git commits 4461f7e9b7d4cdf4ed8857b8d43fa47e8e81bbc7 and 63313a00c450d5f6815f686f465034efc12d9e85

Show
Martha Greenberg added a comment - Fixed in git://github.com/wix/chef.git commits 4461f7e9b7d4cdf4ed8857b8d43fa47e8e81bbc7 and 63313a00c450d5f6815f686f465034efc12d9e85
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

I'm resolving this ticket as fixed because it contains a patch. In the future, please remember to resolve tickets as fixed when you provide a solution. This way we can find tickets with resolutions and add them to the project.

http://wiki.opscode.com/display/chef/How+to+Contribute

Show
Bryan McLellan [Opscode] added a comment - I'm resolving this ticket as fixed because it contains a patch. In the future, please remember to resolve tickets as fixed when you provide a solution. This way we can find tickets with resolutions and add them to the project. http://wiki.opscode.com/display/chef/How+to+Contribute
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

https://github.com/wix/chef/compare/master

https://github.com/wix/chef/commit/63313a00c450d5f6815f686f465034efc12d9e85
https://github.com/wix/chef/commit/4461f7e9b7d4cdf4ed8857b8d43fa47e8e81bbc7

We should drop the 'solaris' case too, as we don't even produce a solaris platform from ohai.

Marking for merge.

Show
Bryan McLellan [Opscode] added a comment - https://github.com/wix/chef/compare/master https://github.com/wix/chef/commit/63313a00c450d5f6815f686f465034efc12d9e85 https://github.com/wix/chef/commit/4461f7e9b7d4cdf4ed8857b8d43fa47e8e81bbc7 We should drop the 'solaris' case too, as we don't even produce a solaris platform from ohai. Marking for merge.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

According to this artice Solaris 8 + 9 used 'usermod -a -G' so that case statement is for older versions of solaris. However, it isn't clear if platform 'solaris' is a valid platform produced by ohai. It's possible that Solaris 8 + 9 would be detected as platform 'solaris2' and would get the new code, in such case a platform_version check would be needed here.

Show
Bryan McLellan [Opscode] added a comment - According to this artice Solaris 8 + 9 used 'usermod -a -G' so that case statement is for older versions of solaris. However, it isn't clear if platform 'solaris' is a valid platform produced by ohai. It's possible that Solaris 8 + 9 would be detected as platform 'solaris2' and would get the new code, in such case a platform_version check would be needed here.
Hide
Permalink
Marc Paradise added a comment - - edited

Merged & pushed to master, w/ minor adjustment for today's earlier whyrun changes for this provider.

Show
Marc Paradise added a comment - - edited Merged & pushed to master, w/ minor adjustment for today's earlier whyrun changes for this provider.

People

  • Assignee:
    Unassigned
    Reporter:
    Martha Greenberg
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: