Run garbage collector before sleeping

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 10.14.0
  • Component/s: Chef Client
  • Labels:

Description

Currently after a chef run the process is put to sleep if on an interval and the GC is not started until it has been woken up. The provided patch kicks the GC on immediately after the run has concluded.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Roberts added a comment -

Pull request: https://github.com/opscode/chef/pull/321

Show
Chris Roberts added a comment - Pull request: https://github.com/opscode/chef/pull/321
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Why not refactor the blocks that sleep up, and avoid adding the few lines of code duplication across multiple files?

Show
Bryan McLellan [Opscode] added a comment - Why not refactor the blocks that sleep up, and avoid adding the few lines of code duplication across multiple files?
Hide
Permalink
Chris Roberts added a comment -

Updated to run the collection within the ensure block at the end of the client run. Removed collection from the client/solo/windows_service files since (I believe) it will be not be required at that point.

Show
Chris Roberts added a comment - Updated to run the collection within the ensure block at the end of the client run. Removed collection from the client/solo/windows_service files since (I believe) it will be not be required at that point.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Great, marked for merge. We will also set run_context to nil to ensure that memory is returned by the GC. Dan has seen issues where the Ruby GC will not reclaim that memory although one would expect it would.

Show
Bryan McLellan [Opscode] added a comment - Great, marked for merge. We will also set run_context to nil to ensure that memory is returned by the GC. Dan has seen issues where the Ruby GC will not reclaim that memory although one would expect it would.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to master, thanks Chris.

Show
Bryan McLellan [Opscode] added a comment - Merged to master, thanks Chris.

People

  • Assignee:
    Chris Roberts
    Reporter:
    Chris Roberts
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: