Webui returning "undefined method `empty?' for nil:NilClass" on invalid files

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 10.14.0
  • Component/s: WebUI
  • Labels:
    None

Description

When wrong files have been uploaded in chef (yes, i know, i'm really wrong). Like vim undofiles, chef-webui can't parse them and error is not catched, then the only result we see is:
undefined method `empty?' for nil:NilClass

See screenshot here: http://d.pr/i/zV3b

I've attached a pull request here : https://github.com/opscode/chef/pull/331
which solves the problem for me.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Arthur Gautier added a comment -

See https://github.com/opscode/chef/pull/331

Show
Arthur Gautier added a comment - See https://github.com/opscode/chef/pull/331
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Looks good, marked for merge.

I need to merge the rails3 branch into master soon, as this may not merge against that.

Show
Bryan McLellan [Opscode] added a comment - Looks good, marked for merge. I need to merge the rails3 branch into master soon, as this may not merge against that.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Thanks Arthur!

Merged to 10-stable and master.

Show
Bryan McLellan [Opscode] added a comment - Thanks Arthur! Merged to 10-stable and master.

People

  • Assignee:
    Unassigned
    Reporter:
    Arthur Gautier
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: