stop_clock NilClass exception on Windows

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Affects Version/s: 10.14.0
  • Fix Version/s: 10.14.0
  • Component/s: None
  • Labels:
    None
  • Environment:

    Windows 7 pro, 10.14.0.beta.3

Description

[2012-07-31T13:04:49-04:00] DEBUG: Sending HTTP Request via GET to api.opscode.com:443/organizations/opscode-btm/nodes/WIN-VQ19BR1IFRD
[2012-07-31T13:04:51-04:00] DEBUG: ---- HTTP Status and Header Data: ----
[2012-07-31T13:04:51-04:00] DEBUG: HTTP 1.1 200 OK
[2012-07-31T13:04:51-04:00] DEBUG: server: nginx/1.0.5
[2012-07-31T13:04:51-04:00] DEBUG: date: Tue, 31 Jul 2012 17:04:51 GMT
[2012-07-31T13:04:51-04:00] DEBUG: content-type: application/json
[2012-07-31T13:04:51-04:00] DEBUG: transfer-encoding: chunked
[2012-07-31T13:04:51-04:00] DEBUG: connection: close
[2012-07-31T13:04:51-04:00] DEBUG: content-encoding: gzip
[2012-07-31T13:04:51-04:00] DEBUG: ---- End HTTP Status/Header Data ----
[2012-07-31T13:04:51-04:00] DEBUG: decompressing gzip response
[2012-07-31T13:04:51-04:00] DEBUG: Extracting run list from JSON attributes provided on command line
[2012-07-31T13:04:51-04:00] DEBUG: Applying attributes from json file
[2012-07-31T13:04:51-04:00] FATAL: Stacktrace dumped to C:/chef/cache/chef-stacktrace.out
[2012-07-31T13:04:51-04:00] DEBUG: NoMethodError: undefined method `stop_clock' for nil:NilClass
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0.beta.3/lib/chef/client.rb:424:in `rescue in do_run'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0.beta.3/lib/chef/client.rb:434:in `do_run'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0.beta.3/lib/chef/client.rb:176:in `run'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0.beta.3/lib/chef/application/client.rb:277:in `block in run_application'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0.beta.3/lib/chef/application/client.rb:264:in `loop'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0.beta.3/lib/chef/application/client.rb:264:in `run_application'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0.beta.3/lib/chef/application.rb:70:in `run'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0.beta.3/bin/chef-client:26:in `<top (required)>'
C:/opscode/chef/bin/chef-client:19:in `load'
C:/opscode/chef/bin/chef-client:19:in `<main>'
[2012-07-31T13:04:51-04:00] FATAL: NoMethodError: undefined method `stop_clock' for nil:NilClass

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

I wandered into OHAI-306 again, which is triggering this failure.

There are a couple issues. platform_version is nil, so we raise an exception in Chef::Platform.find_platform_and_version. In Chef::Client.do_run we rescue this, but before we raise the exception we call run_status.stop_clock but we haven't gotten so fair in Chef::Client.build_node that run_status has been initialized yet.

Show
Bryan McLellan [Opscode] added a comment - I wandered into OHAI-306 again, which is triggering this failure. There are a couple issues. platform_version is nil, so we raise an exception in Chef::Platform.find_platform_and_version. In Chef::Client.do_run we rescue this, but before we raise the exception we call run_status.stop_clock but we haven't gotten so fair in Chef::Client.build_node that run_status has been initialized yet.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

@run_status in Chef::Client.do_run passes @node and @events into Chef::RunStatus but it doesn't appear to consume them itself. I wonder if it's an issue to move the creation of @run_status up to the top of #build_node.

Regardless, we can modify the rescue to check to see if run_status is nil in #do_run.

Show
Bryan McLellan [Opscode] added a comment - @run_status in Chef::Client.do_run passes @node and @events into Chef::RunStatus but it doesn't appear to consume them itself. I wonder if it's an issue to move the creation of @run_status up to the top of #build_node. Regardless, we can modify the rescue to check to see if run_status is nil in #do_run.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Fixed in 3a09e77554c87fbda0c36eb2cb19875aa1522e51 in 10-stable.

Show
Bryan McLellan [Opscode] added a comment - Fixed in 3a09e77554c87fbda0c36eb2cb19875aa1522e51 in 10-stable.

People

  • Assignee:
    Unassigned
    Reporter:
    Bryan McLellan [Opscode]
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: