pkg info may show version in parenthesis in addition to the bare string

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 10.14.0
  • Component/s: None
  • Environment:

    omnios, chef 10.14.beta.3 (build from master 8/12/2012)

Description

The "Version" string may apparently sometimes contain the version again in parenthesis, as observed here:

root@omnios-vagrant:~# pkg info -r tmux | grep Version
       Version: 1.6 (1.6)

This is on OmniOS, I don't know if it does similar on OI/OS. This isn't every package, and a possible workaround is to specify the version number or latest as a resource attribute. When Chef attempts to install a package that has this kind of version specified, it fails.

Recipe:

package "tmux" do
  action :install
end

Output:

[2012-08-13T05:29:36+00:00] INFO: Processing package[tmux] action install (base::default line 2)
[2012-08-13T05:29:36+00:00] DEBUG: Checking package status for tmux
          Name: terminal/tmux
       Summary: terminal multiplexer
         State: Not installed
     Publisher: omnios
       Version: 1.6 (1.6)
 Build Release: 5.11
        Branch: 0.151002
Packaging Date: Thu Apr 19 01:49:01 2012
          Size: 602.12 kB
          FMRI: pkg://omnios/terminal/tmux@1.6,5.11-0.151002:20120419T014901Z
[2012-08-13T05:29:37+00:00] DEBUG: Executing pkg install -q --accept tmux@1.6 (1.6)
[2012-08-13T05:29:37+00:00] DEBUG: ---- Begin output of pkg install -q --accept tmux@1.6 (1.6) ----
[2012-08-13T05:29:37+00:00] DEBUG: STDOUT: 
[2012-08-13T05:29:37+00:00] DEBUG: STDERR: sh: syntax error at line 1: `(' unexpected
[2012-08-13T05:29:37+00:00] DEBUG: ---- End output of pkg install -q --accept tmux@1.6 (1.6) ----
[2012-08-13T05:29:37+00:00] DEBUG: Ran pkg install -q --accept tmux@1.6 (1.6) returned 3

================================================================================
Error executing action `install` on resource 'package[tmux]'
================================================================================

Chef::Exceptions::Exec
----------------------
pkg install -q --accept tmux@1.6 (1.6) returned 3, expected 0
---- Begin output of pkg install -q --accept tmux@1.6 (1.6) ----
STDOUT: STDERR: sh: syntax error at line 1: `(' unexpected
---- End output of pkg install -q --accept tmux@1.6 (1.6) ----

Resource Declaration:
---------------------
# In /tmp/vagrant-chef-1/chef-solo-1/cookbooks/base/recipes/default.rb

  1: package "git"
  2: package "tmux" do
  3:   action :install
  4: end
  5: # zone "test" do

Compiled Resource:
------------------
# Declared in /tmp/vagrant-chef-1/chef-solo-1/cookbooks/base/recipes/default.rb:2:in `from_file'

package("tmux") do
  action [:install]
  retries 0
  retry_delay 2
  package_name "tmux"
  cookbook_name :base
  recipe_name "default"
end

[2012-08-13T05:29:37+00:00] DEBUG: Re-raising exception: Chef::Exceptions::Exec - package[tmux] (base::default line 2) had an error: Chef::Exceptions::Exec: pkg install -q --accept tmux@1.6 (1.6) returned 3, expected 0
---- Begin output of pkg install -q --accept tmux@1.6 (1.6) ----
STDOUT: STDERR: sh: syntax error at line 1: `(' unexpected
---- End output of pkg install -q --accept tmux@1.6 (1.6) ----

It works with either of these:

package "tmux" do
  version "1.6"
  action :install
end

package "tmux" do
  version "latest"
  action :install
end

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
jtimberman added a comment -

Pull request: https://github.com/opscode/chef/pull/364

Show
jtimberman added a comment - Pull request: https://github.com/opscode/chef/pull/364
Hide
Permalink
jtimberman added a comment -

The version in the ()'s is the "human readable" version number, which can contain alphanumeric characters that are not allowed in IPS version strings.

Show
jtimberman added a comment - The version in the ()'s is the "human readable" version number, which can contain alphanumeric characters that are not allowed in IPS version strings.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

A regression test would be really nice. In all cases where we're parsing different data on different systems it is important to make sure this fix isn't regressed at a later date by another fix, or even a fix that effectively reverts this.

Show
Bryan McLellan [Opscode] added a comment - A regression test would be really nice. In all cases where we're parsing different data on different systems it is important to make sure this fix isn't regressed at a later date by another fix, or even a fix that effectively reverts this.
Hide
Permalink
jtimberman added a comment -

Test added and pushed to my branch. The pull request updated.

Show
jtimberman added a comment - Test added and pushed to my branch . The pull request updated.
Hide
Permalink
jtimberman added a comment -

Failed test:

champagne:~/Development/opscode/chef/chef (1.9.3-p194)
master ✗ % rspec spec/unit/provider/package/ips_spec.rb 
Run options:
  include {:focus=>true}
  exclude {:requires_root=>true, :ruby_18_only=>true, :windows_only=>true, :external=>true}

All examples were filtered out; ignoring {:focus=>true}

Chef::Provider::Package::Ips
  when loading current resource
    should create a current resource with the name of the new_resource
    should set the current resources package name to the new resources package name
    should run pkg info with the package name
    should set the installed version to nil on the current resource if package state is not installed
    should set the installed version if package has one
    should return the current resouce
  when installing a package
    should run pkg install with the package name and version
    should run pkg install with the package name and version and options if specified
    should not contain invalid characters for the version string
    should not include the human-readable version in the candidate_version (FAILED - 1)
  when upgrading a package
    should run pkg install with the package name and version
  when uninstalling a package
    should run pkg uninstall with the package name and version
    should run pkg uninstall with the package name and version and options if specified

Failures:

  1) Chef::Provider::Package::Ips when installing a package should not include the human-readable version in the candidate_version
     Failure/Error: @provider.candidate_version.should eql("1.8.4.1")
       
       expected: "1.8.4.1"
            got: "1.8.4.1 (1.8.4p1)"
       
       (compared using eql?)
     # ./spec/unit/provider/package/ips_spec.rb:159:in `block (3 levels) in <top (required)>'

Finished in 0.10073 seconds
13 examples, 1 failure

Failed examples:

rspec ./spec/unit/provider/package/ips_spec.rb:143 # Chef::Provider::Package::Ips when installing a package should not include the human-readable version in the candidate_version

Passing test:

champagne:~/Development/opscode/chef/chef (1.9.3-p194)
CHEF-3360 ✗ % rspec spec/unit/provider/package/ips_spec.rb 
Run options:
  include {:focus=>true}
  exclude {:requires_root=>true, :ruby_18_only=>true, :windows_only=>true, :external=>true}

All examples were filtered out; ignoring {:focus=>true}

Chef::Provider::Package::Ips
  when loading current resource
    should create a current resource with the name of the new_resource
    should set the current resources package name to the new resources package name
    should run pkg info with the package name
    should set the installed version to nil on the current resource if package state is not installed
    should set the installed version if package has one
    should return the current resouce
  when installing a package
    should run pkg install with the package name and version
    should run pkg install with the package name and version and options if specified
    should not contain invalid characters for the version string
    should not include the human-readable version in the candidate_version
  when upgrading a package
    should run pkg install with the package name and version
  when uninstalling a package
    should run pkg uninstall with the package name and version
    should run pkg uninstall with the package name and version and options if specified

Finished in 0.08266 seconds
13 examples, 0 failures
Show
jtimberman added a comment - Failed test: champagne:~/Development/opscode/chef/chef (1.9.3-p194) master ✗ % rspec spec/unit/provider/ package /ips_spec.rb Run options: include {:focus=> true } exclude {:requires_root=> true , :ruby_18_only=> true , :windows_only=> true , :external=> true } All examples were filtered out; ignoring {:focus=> true } Chef::Provider::Package::Ips when loading current resource should create a current resource with the name of the new_resource should set the current resources package name to the new resources package name should run pkg info with the package name should set the installed version to nil on the current resource if package state is not installed should set the installed version if package has one should return the current resouce when installing a package should run pkg install with the package name and version should run pkg install with the package name and version and options if specified should not contain invalid characters for the version string should not include the human-readable version in the candidate_version (FAILED - 1) when upgrading a package should run pkg install with the package name and version when uninstalling a package should run pkg uninstall with the package name and version should run pkg uninstall with the package name and version and options if specified Failures: 1) Chef::Provider::Package::Ips when installing a package should not include the human-readable version in the candidate_version Failure/Error: @provider.candidate_version.should eql( "1.8.4.1" ) expected: "1.8.4.1" got: "1.8.4.1 (1.8.4p1)" (compared using eql?) # ./spec/unit/provider/ package /ips_spec.rb:159:in `block (3 levels) in <top (required)>' Finished in 0.10073 seconds 13 examples, 1 failure Failed examples: rspec ./spec/unit/provider/ package /ips_spec.rb:143 # Chef::Provider::Package::Ips when installing a package should not include the human-readable version in the candidate_version Passing test: champagne:~/Development/opscode/chef/chef (1.9.3-p194) CHEF-3360 ✗ % rspec spec/unit/provider/ package /ips_spec.rb Run options: include {:focus=> true } exclude {:requires_root=> true , :ruby_18_only=> true , :windows_only=> true , :external=> true } All examples were filtered out; ignoring {:focus=> true } Chef::Provider::Package::Ips when loading current resource should create a current resource with the name of the new_resource should set the current resources package name to the new resources package name should run pkg info with the package name should set the installed version to nil on the current resource if package state is not installed should set the installed version if package has one should return the current resouce when installing a package should run pkg install with the package name and version should run pkg install with the package name and version and options if specified should not contain invalid characters for the version string should not include the human-readable version in the candidate_version when upgrading a package should run pkg install with the package name and version when uninstalling a package should run pkg uninstall with the package name and version should run pkg uninstall with the package name and version and options if specified Finished in 0.08266 seconds 13 examples, 0 failures
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to 10-stable

Show
Bryan McLellan [Opscode] added a comment - Merged to 10-stable

People

  • Assignee:
    Unassigned
    Reporter:
    jtimberman
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: