Fix up Smartos Package provider

Pull request here, complete with rspec

https://github.com/opscode/chef/pull/368

-s

Why is the smartos resource and provider left over?

btw, it's hard to tell what changed between the old smartos provider and the pkgin provider because all of the changes are in a single new commit.

I left the original file because I wasn't sure how you wanted to handle backwards compat for anyone using smartos_package.

The pkgin_package provider is in a completely separate file, but I set it as default for the smartos platform.

Does the smartos and pkgin provider provide equivalent functionality?

smartos_package is actually a shortcut resource, which we could change the provider to the pkgin provider and add a deprecation warning to switch to pkgin, then remove the old provider in 11.0.0+.

Yep.

All that changed was some regex matching ...
#{string}-[0-9] vs #{string}-* to help with "apache-worker-2.2.21nb7" situations,

I added a pkgin avail line for candidate resource in case there is a new version available

.. and the requirements.assert

Here's the cookbook version in an easy-to-view file.

https://gist.github.com/someara/pkgin-cookbook/blob/master/libraries/provider_package.rb

-s

Then can you modify the smartos_package resource as discussed?

This would be better as Ruby:

"pkgin avail | grep ^#{package}-[0-9] | awk '{ print $1 }'"

Then add a regression unit test for the example that caused you to change the regex.

I updated the smartos_package provider with an INFO warning.

However, I'm not sure how to add a regression unit test for this...

Here's the issue...
https://gist.github.com/97cc8caf6be4603c35ed

The only way I can see to check for the regex match is to switch from using "pkg_info -E" all together, and parse "pkgin list output" instead.

Right now the smartos_package provider is broken pretty hard. It won't even match "apache"

https://gist.github.com/f857101bf8c370fd20f1

Update to this: I had to copy the provider_package.rb over smartos_package.rb in order to be able to install packages from pkgsrc. It does not work as smartos_package though.

I agree with Jacques about the copy. I additionally had to s/class Pkgin/class SmartOS/ and adapt the regex yet again:

"pkgin avail | egrep ^#{package}'(-|.)[0-9]' | awk '{ print $1 }'"

It wasn't finding "php-5.3.15" when specifying "php-5.3" as the package to install. Now that there's a "php-5.4.x" in pkgsrc, this is relevant.

To us, this is a critical ticket as it means package support is basically broken using the built-in provider. Can the priority be increased? Could some Joyent folks also step up and get this resolved quickly, please>

Hi Guys.

I don't have cycles to take a look at this right now (nor access to a Joyent Smartmachine), but if you want to take a crack at patching the regex, here's the best way to do it.

1) Fork the pkgin cookbook from my github, here
https://github.com/someara/pkgin-cookbook

2) The relevant file is here:
https://github.com/someara/pkgin-cookbook/blob/master/libraries/provider_package.rb

3) Load this cookbook into your run_list, and it will override the broken pkgin provider bits that ship with Chef, allowing you to fix it with a cookbook

4) send a patch upstream to the cookbook

Thanks and good luck!

-s

Pull request with fix: https://github.com/opscode/chef/pull/446

I'm getting a failing test:

5) Chef::Provider::Package::SmartOS load_current_resource when manipulating a resource run pkgin and install the package
     Failure/Error: @provider.load_current_resource
       #<Chef::Provider::Package::SmartOS:0x7fdd293b1df8> received :shell_out! with unexpected arguments
         expected: ("pkg_info -E \"varnish*\"", {:returns=>[0, 1], :env=>nil})
              got: ("/opt/local/sbin/pkg_info -E \"varnish*\"", {:returns=>[0, 1], :env=>nil})
     # /home/btm/src/chef/spec/../lib/chef/provider/package/smartos.rb:47:in `check_package_state'
     # /home/btm/src/chef/spec/../lib/chef/provider/package/smartos.rb:40:in `load_current_resource'
     # /home/btm/src/chef/spec/unit/provider/package/smartos_spec.rb:77

Need to get the tests fixed.

Hi.

I wrote spec for fix up by benr.

Pull request here.
https://github.com/opscode/chef/pull/577

regards,

Merged to master.