[regression] provider_for_resource changes post-10.12.0 breaks node attribute usage in MiniTest::Chef

Hi, Leif Madsen

It looks like the problems are between your code and the minitest chef code for the error you're getting in default_test.rb.

Can you attach server_test.rb? That might have additional clues as that is where the error output is indicating the problems.

FYI, the same errors occur on the mysql cookbook on 10.12.0:

   1) Error:
 test_0001_installs the mysql packages(mysql::server):
 NameError: undefined local variable or method `node' for #<#<Class:0x7fbe1fa2d520>:0x7fbe1fa0c960>
     /var/chef/minitest/mysql/server_test.rb:17:in `test_0001_installs the mysql packages'

But the same self-made tests on my cookbook produce the existing results in testing (which I would expect on chef > 0.10.8):

   6) Failure:
 test_0002_checks if /var/www/webapp exists and has correct permissions(recipe::webapp::test::webapp_tests) [/usr/lib64/ruby/gems/1.8/gems/minitest-chef-handler-0.6.1/lib/minitest-chef-handler/resources.rb:33]:
 The file does not have the expected owner.
 Expected: "apache"
   Actual: nil

Hi Joshua Timberman [Opscode],
The server_test.rb file is the same one as found in the mysql opscode cookbook, version 1.3.0.

The default_test.rb is the one I have created myself.

HTH,
Leif.

Just for fun, I spun up a new EC2 instance to try this out with 10.12.0 clean with only minitest-handler and mysql::server cookbooks in the run_list (just to make sure it wasn't something outside of those that was causing confusion). I obtain the same output with the mysql::server cookbook from it's tests:

 Run options: -v --seed 56490
 
 # Running tests:
 
 mysql::server#test_0001_installs_the_mysql_packages = 
 0.00 s = E
 mysql::server#test_0002_has_a_config_directory = 
 0.00 s = E
 mysql::server#test_0004_creates_a_my_cnf = 
 0.00 s = E
 mysql::server#test_0003_runs_as_a_daemon = 
 0.00 s = E
 mysql::server::debian#test_0001_creates_a_config_file_for_service_control = 
 0.00 s = E
 
 
 Finished tests in 0.100402s, 49.7998 tests/s, 0.0000 assertions/s.
 
   1) Error:
 test_0001_installs_the_mysql_packages(mysql::server):
 NameError: undefined local variable or method `node' for #<#<Class:0x7fb913ed18f8>:0x7fb913ebcca0>
     /var/chef/minitest/mysql/server_test.rb:17:in `test_0001_installs_the_mysql_packages'
 
   2) Error:
 test_0002_has_a_config_directory(mysql::server):
 NameError: undefined local variable or method `node' for #<#<Class:0x7fb913ed18f8>:0x7fb913ebba08>
     /var/chef/minitest/mysql/server_test.rb:22:in `test_0002_has_a_config_directory'
 
   3) Error:
 test_0004_creates_a_my_cnf(mysql::server):
 NameError: undefined local variable or method `node' for #<#<Class:0x7fb913ed18f8>:0x7fb913eba7c0>
     /var/chef/minitest/mysql/server_test.rb:28:in `test_0004_creates_a_my_cnf'
 
   4) Error:
 test_0003_runs_as_a_daemon(mysql::server):
 NameError: undefined local variable or method `node' for #<#<Class:0x7fb913ed18f8>:0x7fb913eb9528>
     /var/chef/minitest/mysql/server_test.rb:25:in `test_0003_runs_as_a_daemon'
 
   5) Error:
 test_0001_creates_a_config_file_for_service_control(mysql::server::debian):
 NameError: undefined local variable or method `node' for #<#<Class:0x7fb913ece8d8>:0x7fb913eb5cc0>
     /var/chef/minitest/mysql/server_test.rb:32:in `test_0001_creates_a_config_file_for_service_control'
 
 5 tests, 0 assertions, 0 failures, 5 errors, 0 skips

So at this point, I'm unsure where the problem lies; either with Chef, the tests in the mysql cookbook, or minitest-chef-handler...

The errors seem to indicate that you're calling methods that don't exist (in the case of the call to node) or with the wrong number of arguments in this error:

   6) Error:
 test_0002_checks if /var/www/voiceaxis exists and has correct permissions(recipe::webapp::test::webapp_tests):
 ArgumentError: wrong number of arguments (1 for 2)
     /var/chef/minitest/va-webapp/default_test.rb:15:in `test_0002_checks if /var/www/voiceaxis exists and has correct permissions'

At first glance, these don't look like bugs in Chef itself, but more investigation is needed to rule it out.

@andrewcrump

The examples provided are directly from the mysql cookbook, so if there is an implementation error, it would exist in that cookbooks helpers.rb file.

I've withered down the issues with the method of how mysql cookbook includes the MiniTest::Chef::* stuff, so I'm going to open a separate issue for that. I'm also updating the subject of this issue to be a request to fix the node issues as Andrew has verified since that is the underlying issue here. I'm hoping this can get triaged and made a blocker for an upcoming bug fix release since it appears to be a regression and makes MiniTest::Chef not very useful. Thanks!

Thanks to @andrewcrump for pointing things out, looks like this can be fixed in minitest-chef-handler directly. I'm opening a pull request with the changes on minitest-chef-handler. The other issue I reported is a problem with how things are loaded in the helper for the mysql cookbook, but that is really a separate issue for now.

I think this issue can be closed.

Closing this as I believe no change is really needed in Chef, although it would be nice for the calls to have been made backwards compatible.

Pushed a workaround to 10-stable.

It isn't easy determining what internal methods we can refactor without breaking external tools that poke into the internals. In this case, we've added backward compatibility that should be safe.

421b00e3c0681b40e43349b79285cb3343479e6b

Awesome thanks!

Added link to ticket that references that pull request to fix the mysql issues discussed in this ticket.

And pull request that updates minitest-chef-handler to use the new method with backwards compatibility with the old method: https://github.com/calavera/minitest-chef-handler/pull/33