Resources need a retry parameter which allows the action to repeat a set number of times until success is achieved.

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 0.5.1, 0.5.2, 0.5.4, 0.5.6, 0.6.0, 0.6.2, 0.7.0, 0.7.2, 0.7.4, 0.7.6, 0.7.8, 0.7.10, 0.7.12, 0.7.14, 0.7.16, 0.8.2, 0.8.4, 0.8.6, 0.8.8, 0.8.10, 0.8.12, 0.8.14, 0.8.16, 0.9.0, 0.9.2, 0.9.4, 0.9.6, 0.9.8
  • Fix Version/s: 0.10.4
  • Component/s: Chef Client
  • Labels:
    None
  • Environment:

    any

Description

gem_package needs to rescue connection errors and do exponential backoff and retry since rubyforge is unavailable often and this ends up ruining a whole chef run. i;d rather have chef sit there and retry to install a gem a few times before it gives up and fails as often you can just retry to install the gem and it will work.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
AJ Christensen added a comment -

There also appears to be no specifications at all for the rubygems provider.

Show
AJ Christensen added a comment - There also appears to be no specifications at all for the rubygems provider.
Hide
Permalink
AJ Christensen added a comment -

Going to bump this from 0.5.2 to unknown as I don't consider it important enough to block release.

Ez, when you wake up if there is still time feel free to complete this for the milestone and have a word to Adam about getting it in.

Show
AJ Christensen added a comment - Going to bump this from 0.5.2 to unknown as I don't consider it important enough to block release. Ez, when you wake up if there is still time feel free to complete this for the milestone and have a word to Adam about getting it in.
Hide
Permalink
Adam Jacob added a comment -

This is going in 0.5.4, hook or by crook.

Show
Adam Jacob added a comment - This is going in 0.5.4, hook or by crook.
Hide
Permalink
Adam Jacob added a comment -

Bumping these to 0.5.6

Show
Adam Jacob added a comment - Bumping these to 0.5.6
Hide
Permalink
AJ Christensen added a comment -

Renaming.

Want to make it so that any resource can have a configurable number of retries (similar to ignore_failure true)

Show
AJ Christensen added a comment - Renaming. Want to make it so that any resource can have a configurable number of retries (similar to ignore_failure true)
Hide
Permalink
AJ Christensen added a comment -

Have the code for this almost complete, going into 0.7.4

Show
AJ Christensen added a comment - Have the code for this almost complete, going into 0.7.4
Hide
Permalink
Adam Jacob added a comment -

This is still a good idea!

Show
Adam Jacob added a comment - This is still a good idea!
Hide
Permalink
Michael Leinartas added a comment -

Retry added to the base resource here:
http://github.com/mleinart/chef/tree/CHEF-39

Unit tests updated as well.

Show
Michael Leinartas added a comment - Retry added to the base resource here: http://github.com/mleinart/chef/tree/CHEF-39 Unit tests updated as well.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Can someone please add a retry timer to limit the immediate retries and double-check the test coverage? Thanks.

Show
Bryan McLellan [Opscode] added a comment - Can someone please add a retry timer to limit the immediate retries and double-check the test coverage? Thanks.
Hide
Permalink
Daniel DeLeo added a comment -

bulk updating fix versions to next release

Show
Daniel DeLeo added a comment - bulk updating fix versions to next release
Hide
Permalink
Dan Peterson added a comment -

So would it just take some backoff delay to get this merged?

Show
Dan Peterson added a comment - So would it just take some backoff delay to get this merged?
Hide
Permalink
Dan Peterson added a comment -

In https://github.com/dpiddy/chef/tree/CHEF-39:

  • Rebased to latest master
  • Added retry_delay for sleeping between retries
  • Added a Runner spec to verify retries work if specified
Show
Dan Peterson added a comment - In https://github.com/dpiddy/chef/tree/CHEF-39: Rebased to latest master Added retry_delay for sleeping between retries Added a Runner spec to verify retries work if specified
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

This patch has been merged to opscode/master and will be included in the next release. Thank you for contributing to Chef!

Show
Bryan McLellan [Opscode] added a comment - This patch has been merged to opscode/master and will be included in the next release. Thank you for contributing to Chef!
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Reopening for fix version change.

Show
Bryan McLellan [Opscode] added a comment - Reopening for fix version change.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

0.10.2 was a security release, 0.10.4 is the next maintenance release.

Show
Bryan McLellan [Opscode] added a comment - 0.10.2 was a security release, 0.10.4 is the next maintenance release.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Bulk edit: this ticket should have been previously merged for 0.10.2, but will be released in 0.10.4

Show
Bryan McLellan [Opscode] added a comment - Bulk edit: this ticket should have been previously merged for 0.10.2, but will be released in 0.10.4

People

  • Assignee:
    Daniel DeLeo
    Reporter:
    Ezra Zygmuntowicz
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: