chef-server version needs to not rely on walking gem objectspace

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Won't Fix
  • Affects Version/s: 0.7.4
  • Fix Version/s: 0.8.10
  • Component/s: Chef Server
  • Labels:
    None

Description

In order to be able to create platform-specific packages for chef-server, we need to determine the version in a way that doesn't rely on RubyGems.

As it is now (chef 0.7.4, 0.7.5), the CHEF_SERVER_VERSION is set in the Rakefile, which is used in building the chef-server gem, and set in the running app by crawling the ObjectSpace in the chef-server program.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
jtimberman added a comment -

I've "fixed" this in jtimberman/chef-468. I don't know if its a properly correct way to go about it, since the version constant gets defined in a couple places. This is to try and get things running smoothly on Debian, which doesn't want people to install anything in RubyGems, or require that particular RubyGems are installed.

Show
jtimberman added a comment - I've "fixed" this in jtimberman/chef-468. I don't know if its a properly correct way to go about it, since the version constant gets defined in a couple places. This is to try and get things running smoothly on Debian, which doesn't want people to install anything in RubyGems, or require that particular RubyGems are installed.
Hide
Permalink
jtimberman added a comment -

We'll revisit this for 0.8.0, in the mean time use quilt to patch the chef-server binary with the version so it will run outside a gem'd environment.

Show
jtimberman added a comment - We'll revisit this for 0.8.0, in the mean time use quilt to patch the chef-server binary with the version so it will run outside a gem'd environment.
Hide
Permalink
Adam Jacob added a comment -

Setting this to a blocker, as we can't release 0.8.0 without it being fixed.

Show
Adam Jacob added a comment - Setting this to a blocker, as we can't release 0.8.0 without it being fixed.
Hide
Permalink
Christopher Brown added a comment -

Per our conversation, monkey patch ex post facto for debian. Downgrading ticket severity from blocker

Show
Christopher Brown added a comment - Per our conversation, monkey patch ex post facto for debian. Downgrading ticket severity from blocker
Hide
Permalink
Christopher Brown added a comment -

Feh, changed back to blocker, but plan for Debian this time around again is to monkey-patch ex post facto.

Show
Christopher Brown added a comment - Feh, changed back to blocker, but plan for Debian this time around again is to monkey-patch ex post facto.
Hide
Permalink
jtimberman added a comment -

We won't patch Chef directly for this. The Debian packaging will remove "require 'rubygems'" from source files via quilt patch, and we patch the dependency method in Merb to do the right thing. The Merb gem plugin will be available in the Merb packages via Depends on RubyGems, but we won't rely on it via the quilt patch.

Show
jtimberman added a comment - We won't patch Chef directly for this. The Debian packaging will remove "require 'rubygems'" from source files via quilt patch, and we patch the dependency method in Merb to do the right thing. The Merb gem plugin will be available in the Merb packages via Depends on RubyGems, but we won't rely on it via the quilt patch.

People

  • Assignee:
    jtimberman
    Reporter:
    jtimberman
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: