in deploy provider, callback-defined resources are executed in all subsequent callbacks

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 0.7.12
  • Fix Version/s: 0.7.14
  • Component/s: Chef Client
  • Labels:
    None

Description

for example a gem_package specified under the before_migrate callback would also be run in before_symlink, before_restart and after_restart.

Seems to be due to the repeated calling of Chef::Runner.converge with the same Chef::ResourceCollection.

I have a patch, will push it when I've got the jira id

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Lachie Cox added a comment -

Topic branch pushed to:
http://github.com/plustwo/chef/tree/CHEF-602

please review and prosper!

Show
Lachie Cox added a comment - Topic branch pushed to: http://github.com/plustwo/chef/tree/CHEF-602 please review and prosper!
Lachie Cox made changes -
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Assignee Lachie Cox [ lachie ] AJ Christensen [ aj ]
Fix Version/s 0.7.12 [ 10030 ]
Fix Version/s 0.7.12rc0 [ 10031 ]
Resolution Fixed [ 1 ]
Hide
Permalink
AJ Christensen added a comment -

Triage

Show
AJ Christensen added a comment - Triage
AJ Christensen made changes -
Fix Version/s 0.7.12rc0 [ 10031 ]
Affects Version/s 0.7.12rc0 [ 10031 ]
Priority Major [ 3 ] Critical [ 2 ]
Component/s Resources [ 10004 ]
Hide
Permalink
AJ Christensen added a comment -

Merged danielsdeleo/CHEF-602 (sorry Lachie <3)

Show
AJ Christensen added a comment - Merged danielsdeleo/ CHEF-602 (sorry Lachie <3)
AJ Christensen made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Bryan McLellan [Opscode] made changes -
Component/s Providers [ 10005 ]
Bryan McLellan [Opscode] made changes -
Component/s Chef Client [ 10000 ]
Component/s Resources [ 10004 ]
Bryan McLellan [Opscode] made changes -
Workflow jira [ 10940 ] New OSS [ 18768 ]
Bryan McLellan [Opscode] made changes -
Workflow New OSS [ 18768 ] OSS: Product Management [ 26676 ]
Transition Time In Source Status Execution Times Last Executer Last Execution Date
Open Open Resolved Resolved
2m 36s 1 Lachie Cox 09/Oct/09 1:00 AM
Resolved Resolved Closed Closed
2h 55m 1 AJ Christensen 09/Oct/09 3:56 AM

People

  • Assignee:
    AJ Christensen
    Reporter:
    Lachie Cox
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: