http://github.com/btm/chef/tree/chef-634

I was playing with this and was able to reproduce this 100% of the time with 100% valid json according to yajl and other json verifiers.

Credit goes to StormSilver for the failjson.

Step 1, login, edit node, add networking child (can be anything really)
Step 2, insert failjson into this new thing, hit save... it says it's fine right? right so hit save...
Step 3, oops silent rescue brings you back to step 1 without your changes.

See http://gist.github.com/220882

Actually, I was able to reduce the problem further. It's because of the \t character which should be totally okay.

1. Create a new node.
2. Edit the node and paste the following json into the node, replacing anything that's there.
3. Watch as it blows up. Applying btm's patch allows you to see the error:
Parser Error 500
574: unexpected token at '{"foo":{"bar":"baz quux"}}'

failjson:
{
"foo": { "bar": "baz\tquux" }
}

btm's patch:
http://github.com/btm/chef/commit/f29b3c0848c59cc1dc48f93003140179b0a79889

And a ruby program that fails with the same JSON:
http://gist.github.com/220888

There's definitely a second bug to be had where the UI expands the tabs when they're loaded but fails to escape them again when it tries to write them. It shouldn't convert them at all. I found this rescue because of tabs, escaped unicode in the JSON in my case.

Can you re-base your patch against the current master (0.8)?

Also, it looks like we should resolve this bug, and open a new one regarding escaping and valid JSON creation.

UI/jsoneditor bug opened as CHEF-659

http://github.com/btm/chef/tree/chef-634 (rebased against 0.8.0)

untested, I still haven't gotten 0.8 running, but it should be fine.

triage

Thanks, everyone. BTM's patch is applied to make the messages more verbose, and pcrossley's new JSON editor does proper encoding.