Cookbook libraries do not sync subdirectories

Details

  • Type: Bug Bug
  • Status: Confirmed Confirmed
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 0.7.14, 11.4.0-client
  • Fix Version/s: None
  • Component/s: Chef Client, Chef Server
  • Labels:
    None

Description

The culprit is in cookbook_loader:

load_files_unless_basename(
  File.join(cookbook, "libraries", "*.rb"),               
  cookbook_settings[cookbook_name][:lib_files]
)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Adam Jacob added a comment -

We should fix this for 0.8.0, since it's clearly an obvious oversight.

Show
Adam Jacob added a comment - We should fix this for 0.8.0, since it's clearly an obvious oversight.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

e38cd34fb4ed4e4cd6442e320ad0602d5de382b4 created chef/lib/chef/cookbook/cookbook_version_loader.rb
78ff1901db31fc8939d03a4019c94383f36b7e3c refactored Chef::CookbookLoader to use it

https://github.com/opscode/chef/blob/master/chef/lib/chef/cookbook/cookbook_version_loader.rb#L49

Looks like we still don't load subdirectories.

def load_cookbooks
        load_as(:attribute_filenames, 'attributes', '*.rb')
        load_as(:definition_filenames, 'definitions', '*.rb')
        load_as(:recipe_filenames, 'recipes', '*.rb')
        load_as(:library_filenames, 'libraries', '*.rb')
        load_recursively_as(:template_filenames, "templates", "*")
        load_recursively_as(:file_filenames, "files", "*")
        load_recursively_as(:resource_filenames, "resources", "*.rb")
        load_recursively_as(:provider_filenames, "providers", "*.rb")
        load_root_files
Show
Bryan McLellan [Opscode] added a comment - e38cd34fb4ed4e4cd6442e320ad0602d5de382b4 created chef/lib/chef/cookbook/cookbook_version_loader.rb 78ff1901db31fc8939d03a4019c94383f36b7e3c refactored Chef::CookbookLoader to use it https://github.com/opscode/chef/blob/master/chef/lib/chef/cookbook/cookbook_version_loader.rb#L49 Looks like we still don't load subdirectories. def load_cookbooks load_as(:attribute_filenames, 'attributes', '*.rb') load_as(:definition_filenames, 'definitions', '*.rb') load_as(:recipe_filenames, 'recipes', '*.rb') load_as(:library_filenames, 'libraries', '*.rb') load_recursively_as(:template_filenames, "templates" , "*" ) load_recursively_as(:file_filenames, "files" , "*" ) load_recursively_as(:resource_filenames, "resources" , "*.rb" ) load_recursively_as(:provider_filenames, "providers" , "*.rb" ) load_root_files
Hide
Permalink
Karel Minarik added a comment -

Hello, the Elasticsearch cookbook is still being plagued by this issue, see: https://github.com/karmi/cookbook-elasticsearch/issues/44

One of the solutions would be to move all Ruby files to `library` (see https://github.com/karmi/cookbook-elasticsearch/pull/45/files), but this seems just very inconsistent and arbitrary.

Are there any plans to fix this issue?

Show
Karel Minarik added a comment - Hello, the Elasticsearch cookbook is still being plagued by this issue, see: https://github.com/karmi/cookbook-elasticsearch/issues/44 One of the solutions would be to move all Ruby files to `library` (see https://github.com/karmi/cookbook-elasticsearch/pull/45/files ), but this seems just very inconsistent and arbitrary. Are there any plans to fix this issue?
Hide
Permalink
Miah Johnson added a comment -

I could be wrong, but this seems like a easy enough fix. Any reasons why this wouldn't work?

https://github.com/opscode/chef/pull/760

Show
Miah Johnson added a comment - I could be wrong, but this seems like a easy enough fix. Any reasons why this wouldn't work? https://github.com/opscode/chef/pull/760
Hide
Permalink
Teemu Matilainen added a comment -

chef-solo-search has the same problem: https://github.com/edelight/chef-solo-search/issues/30

Show
Teemu Matilainen added a comment - chef-solo-search has the same problem: https://github.com/edelight/chef-solo-search/issues/30
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Miah Johnson That's fine, but we need to test it to make sure the other side of this works. A unit test for starters, and then at least a manual black box testing against a Chef 10 + 11 server to make sure there's nothing there that won't bring the files all the way across.

Show
Bryan McLellan [Opscode] added a comment - Miah Johnson That's fine, but we need to test it to make sure the other side of this works. A unit test for starters, and then at least a manual black box testing against a Chef 10 + 11 server to make sure there's nothing there that won't bring the files all the way across.

People

  • Assignee:
    Unassigned
    Reporter:
    Chris Walters
Vote (5)
Watch (8)

Dates

  • Created:
    Updated: