Chef should complain when it can't find any cookbooks

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 0.7.14
  • Fix Version/s: 0.8.12
  • Component/s: Chef Solo
  • Labels:
    None

Description

When you install Chef and run chef-solo without any cookbooks, it returns happy. Instead, it should complain that it couldn't find any cookbooks and exit with an error, since it's obviously a solo.rb mis-configuration. This will really help beginners, and even experts like me who occasionally mis-configure something, then wonder why my recipe changes aren't being picked up.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Adam Jacob added a comment -

Agreed - we should issue a warning here.

Show
Adam Jacob added a comment - Agreed - we should issue a warning here.
Hide
Permalink
Dan DeMaggio added a comment -

A warning will only help in interactive mode. If I run chef with no cookbooks, that's a mis-configuration, which should be a hard error so upstream shell scripts can detect it.. (i.e. cron jobs, etc.) If you're going to exit with an error, there should be something in the fatal log, not just the warning log.

Show
Dan DeMaggio added a comment - A warning will only help in interactive mode. If I run chef with no cookbooks, that's a mis-configuration, which should be a hard error so upstream shell scripts can detect it.. (i.e. cron jobs, etc.) If you're going to exit with an error, there should be something in the fatal log, not just the warning log.
Hide
Permalink
Adam Jacob added a comment -

The right thing to do here for solo is as Dan describes - exit with a non-0 exit code and log about the lack of any cookbooks.

For the chef-client, you should essentially just log - it's quite possible you'll be unconfigured at first.

Show
Adam Jacob added a comment - The right thing to do here for solo is as Dan describes - exit with a non-0 exit code and log about the lack of any cookbooks. For the chef-client, you should essentially just log - it's quite possible you'll be unconfigured at first.
Hide
Permalink
Nuo Yan added a comment -

Please pull from nuoyan/chef/CHEF-724.

Added check in the converge method in chef/lib/chef/client.rb.

If it's a chef-client run, check if the node has an empty runlist and if so, log a warn message.

If it's a chef-solo run, go through the Chef::Config[:cookbook_path] list, which may either be a string or array, and check if there's any file exist in the path provided. For example, if Chef::Config[:cookbook_path] is ['/Users/nuoyan/cookbooks', '/Users/nuoyan/kitchen'], it checks if there are files in any of those directories, if so, break the loop and go on to Chef::Compile. If there is no file in all of the paths in the list, raise CookbookNotFound error and log as fatal.

Show
Nuo Yan added a comment - Please pull from nuoyan/chef/ CHEF-724 . Added check in the converge method in chef/lib/chef/client.rb. If it's a chef-client run, check if the node has an empty runlist and if so, log a warn message. If it's a chef-solo run, go through the Chef::Config [:cookbook_path] list, which may either be a string or array, and check if there's any file exist in the path provided. For example, if Chef::Config [:cookbook_path] is ['/Users/nuoyan/cookbooks', '/Users/nuoyan/kitchen'] , it checks if there are files in any of those directories, if so, break the loop and go on to Chef::Compile. If there is no file in all of the paths in the list, raise CookbookNotFound error and log as fatal.
Hide
Permalink
Daniel DeLeo added a comment -

Pushed the fix to master. Thanks for the bug report Dan, and nice work on the fix Nuo.

Show
Daniel DeLeo added a comment - Pushed the fix to master. Thanks for the bug report Dan, and nice work on the fix Nuo.
Hide
Permalink
Daniel DeLeo added a comment -

setting the correct fixversion

Show
Daniel DeLeo added a comment - setting the correct fixversion

People

  • Assignee:
    Daniel DeLeo
    Reporter:
    Dan DeMaggio
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: