added a comment - - edited
As Adam said - this is less priority than 0.8 work. Actually this 828 fix also requires a re-release of the Mixlib-Cli gem (on gems.opscode.com) too.
But we would really like someone else familiar with Chef/Ohai sources to come forward to check the code. Meaning grep for the all references on ARGV.
This is just to be sure that there is no old code which implicitly assumes that ARGV must == 0. Although any early ARGV manipulation - before its given to the Mixlib mixin method "parse_options()" is absoloutely fine. Usually the parse_options method is called / overloaded from application.rb class.
This patch only prevents ARGV from being deleted by mixlib-cli processing. So generally other kinds of ARGV checks and manipulations are OK.
The applications that use mixlib-cli are:
Apps that don't use mixlib-cli manually parse their ARGV arguments. Or will use the optionparser parse! method directly.
They are unaffected. These are:
chef-server (thor task)
These components all live in either the main chef repo, or the ohai repo (of course don't forget about ohai).
As for other components (not listed above), google has turned up nothing outside chef family that uses mixlib-cli.
Unless someone already knows of other gems (outside chef and not on github) that use mixlib-cli - well that seems unlikely.