Chef::Node::Attribute can't handle false/nil

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.9.10
  • Component/s: Chef Client, Chef Solo
  • Labels:
    None
  • Environment:

    Centos

Description

The "has_key?" routine in Chef::Node::Attribute actually fetches the value, instead of checking for it's existence. If the value is false/nil, then it doesn't exist. Chef gets a "method not found" when trying to access Ohai attributes that are false (using the node.blah.blah notation. It works with node.blah[:blah] notation).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Adam Jacob added a comment -

This is an easy fix to an irritating bug.

Show
Adam Jacob added a comment - This is an easy fix to an irritating bug.
Hide
Permalink
Toomas Pelberg added a comment -

Please merge with: http://github.com/toomasp/chef/tree/CHEF-871

Show
Toomas Pelberg added a comment - Please merge with: http://github.com/toomasp/chef/tree/CHEF-871
Hide
Permalink
Daniel DeLeo added a comment -

Merged. I added a bit of cleanup to Chef::Node::Attribute as well. Thanks for the patch Toomas!

Show
Daniel DeLeo added a comment - Merged. I added a bit of cleanup to Chef::Node::Attribute as well. Thanks for the patch Toomas!

People

  • Assignee:
    Daniel DeLeo
    Reporter:
    Dan DeMaggio
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: