Chef::Node::Attribute can't handle false/nil

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.9.10
  • Component/s: Chef Client, Chef Solo
  • Labels:
    None
  • Environment:

    Centos

Description

The "has_key?" routine in Chef::Node::Attribute actually fetches the value, instead of checking for it's existence. If the value is false/nil, then it doesn't exist. Chef gets a "method not found" when trying to access Ohai attributes that are false (using the node.blah.blah notation. It works with node.blah[:blah] notation).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Adam Jacob added a comment -

This is an easy fix to an irritating bug.

Show
Adam Jacob added a comment - This is an easy fix to an irritating bug.
Adam Jacob made changes -
Field Original Value New Value
Priority Minor [ 4 ] Critical [ 2 ]
Triage Status [Triaged]
Adam Jacob made changes -
Affects Version/s 0.7.14 [ 10030 ]
Fix Version/s 0.9.8 [ 10079 ]
Daniel DeLeo made changes -
Fix Version/s 0.9.10 [ 10080 ]
Fix Version/s 0.9.8 [ 10079 ]
Hide
Permalink
Toomas Pelberg added a comment -

Please merge with: http://github.com/toomasp/chef/tree/CHEF-871

Show
Toomas Pelberg added a comment - Please merge with: http://github.com/toomasp/chef/tree/CHEF-871
Toomas Pelberg made changes -
Status Open [ 1 ] Resolved [ 5 ]
Assignee Daniel DeLeo [ dan@kallistec.com ]
Resolution Fixed [ 1 ]
Hide
Permalink
Daniel DeLeo added a comment -

Merged. I added a bit of cleanup to Chef::Node::Attribute as well. Thanks for the patch Toomas!

Show
Daniel DeLeo added a comment - Merged. I added a bit of cleanup to Chef::Node::Attribute as well. Thanks for the patch Toomas!
Daniel DeLeo made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Bryan McLellan [Opscode] made changes -
Workflow jira [ 11305 ] New OSS [ 19001 ]
Bryan McLellan [Opscode] made changes -
Workflow New OSS [ 19001 ] OSS: Product Management [ 26909 ]
Transition Time In Source Status Execution Times Last Executer Last Execution Date
Open Open Resolved Resolved
209d 5h 7m 1 Toomas Pelberg 09/Aug/10 7:18 PM
Resolved Resolved Closed Closed
13d 9h 8m 1 Daniel DeLeo 23/Aug/10 4:27 AM

People

  • Assignee:
    Daniel DeLeo
    Reporter:
    Dan DeMaggio
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: