Chef

Rollback on deploy errors

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.7.16, 0.8.2, 0.10.0
  • Fix Version/s: 0.10.6
  • Component/s: Providers
  • Labels:
    None
  • Triage Status:
    Triaged

Description

From chef wiki: "The drawback to the revision deploy strategy is that if the deploy fails for any reason, and you want to re-deploy with the same code, you'll need to manually set the action to :force_deploy". So it would be nice if chef detects errors on deployment and rollbacks to previous version if such error occurs.

Here implementation - https://github.com/valodzka/chef/commits/om/

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Adam Jacob added a comment - 26/Feb/10 11:24 PM

Pavel, this looks like a good patch - unfortunately, it's also fairly substantial, and we're just days away from shipping 0.8.2. I'm assigning this ticket to the 0.8.4 release, and we'll get it reviewed and merged ASAP after we release.

Show
Adam Jacob added a comment - 26/Feb/10 11:24 PM Pavel, this looks like a good patch - unfortunately, it's also fairly substantial, and we're just days away from shipping 0.8.2. I'm assigning this ticket to the 0.8.4 release, and we'll get it reviewed and merged ASAP after we release.
Hide
Permalink
Daniel DeLeo added a comment - 06/May/10 9:54 PM

Bulk re-assigning the fix version to 0.8.14

Show
Daniel DeLeo added a comment - 06/May/10 9:54 PM Bulk re-assigning the fix version to 0.8.14
Hide
Permalink
Dimitri Krassovski added a comment - 08/Nov/10 4:00 PM

This is still in the same state as it was, no fix has been applied

Show
Dimitri Krassovski added a comment - 08/Nov/10 4:00 PM This is still in the same state as it was, no fix has been applied
Hide
Permalink
Bryan McLellan added a comment - 03/May/11 5:10 PM

This is fairly simple and good, however it changes the default behavior. We need this to only happen when an attribute is set.

Show
Bryan McLellan added a comment - 03/May/11 5:10 PM This is fairly simple and good, however it changes the default behavior. We need this to only happen when an attribute is set.
Hide
Permalink
Pavel Valodzka added a comment - 05/May/11 6:21 PM

I rebased changes again 0.10 (https://github.com/valodzka/chef/commits/om/) and make rollback optional and off by default.

Show
Pavel Valodzka added a comment - 05/May/11 6:21 PM I rebased changes again 0.10 (https://github.com/valodzka/chef/commits/om/) and make rollback optional and off by default.
Hide
Permalink
Bryan McLellan added a comment - 07/Jul/11 6:00 PM

Reopening for fix version change.

Show
Bryan McLellan added a comment - 07/Jul/11 6:00 PM Reopening for fix version change.
Hide
Permalink
Bryan McLellan added a comment - 07/Jul/11 6:02 PM

0.10.2 was a security release, 0.10.4 is the next maintenance release.

Show
Bryan McLellan added a comment - 07/Jul/11 6:02 PM 0.10.2 was a security release, 0.10.4 is the next maintenance release.
Hide
Permalink
Bryan McLellan added a comment - 07/Jul/11 6:04 PM

Bulk edit: this ticket should have been previously merged for 0.10.2, but will be released in 0.10.4

Show
Bryan McLellan added a comment - 07/Jul/11 6:04 PM Bulk edit: this ticket should have been previously merged for 0.10.2, but will be released in 0.10.4
Hide
Permalink
Bryan McLellan added a comment - 09/Aug/11 2:15 AM

Missed due to the bulk edit workaround due to 0.10.2, merging next release.

Show
Bryan McLellan added a comment - 09/Aug/11 2:15 AM Missed due to the bulk edit workaround due to 0.10.2, merging next release.
Hide
Permalink
Bryan McLellan added a comment - 29/Sep/11 12:35 PM

This patch has been merged to opscode/master and will be included in the next release. Thank you for contributing to Chef!

Show
Bryan McLellan added a comment - 29/Sep/11 12:35 PM This patch has been merged to opscode/master and will be included in the next release. Thank you for contributing to Chef!

People

Vote (0)
Watch (0)

Dates

  • Created:
    01/Feb/10 6:58 PM
    Updated:
    29/Sep/11 12:35 PM
    Resolved:
    09/Aug/11 2:15 AM
Atlassian JIRA (v4.3#614-r144677) | Report a problem
Powered by a free Atlassian JIRA open source license for Chef and Ohai. Try JIRA - bug tracking software for your team.