git provider fetch strategy will not get all updates

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.7.16
  • Fix Version/s: 0.8.2
  • Component/s: None
  • Labels:
    None

Description

The git provider only runs "git fetch --tags", however git fetch --tags does not update branch heads. It should be also running "git fetch". Alternatively, I believe you could also run "git remote update" but I'm not 100% sure that is the same so I'll patch git.rb provider to do a git fetch before git fetch --tags.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Kris Rasmussen added a comment -

We are running tests to ensure this works now.

Show
Kris Rasmussen added a comment - We are running tests to ensure this works now.
Kris Rasmussen made changes -
Field Original Value New Value
Status Open [ 1 ] In Progress [ 3 ]
Hide
Permalink
Kris Rasmussen added a comment -

fix is at:
http://github.com/krisr/chef/tree/CHEF-932

Show
Kris Rasmussen added a comment - fix is at: http://github.com/krisr/chef/tree/CHEF-932
Hide
Permalink
Kris Rasmussen added a comment -

Confirmed that this works.

Show
Kris Rasmussen added a comment - Confirmed that this works.
Kris Rasmussen made changes -
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Kris Rasmussen made changes -
Assignee Kris Rasmussen [ kris ] Adam Jacob [ adam ]
Hide
Permalink
Daniel DeLeo added a comment -

This issue and CHEF-905 are duplicates of each other. Normally, I'd just close this one and mark it as a dupe, but this one has a patch from a CLA'd contributor, so I'm marking the other as a duplicate.

Show
Daniel DeLeo added a comment - This issue and CHEF-905 are duplicates of each other. Normally, I'd just close this one and mark it as a dupe, but this one has a patch from a CLA'd contributor, so I'm marking the other as a duplicate.
Hide
Permalink
Adam Jacob added a comment -

Thanks for the fix, Kris!

This is merged and pushed to opscode/master.

Show
Adam Jacob added a comment - Thanks for the fix, Kris! This is merged and pushed to opscode/master.
Adam Jacob made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Hide
Permalink
Kris Rasmussen added a comment -

Hey Adam,

I apologize, but it looks like I didn't push my last commit on this one. The one you merged does not specify the remote to fetch from so it will fetch all remotes. This is probably not a big deal, but I had specified the remote explicitly to be more consistent with the rest of the code. You can probably merge again. We tested with this last commit, not the first one.

Thanks,
Kris

Show
Kris Rasmussen added a comment - Hey Adam, I apologize, but it looks like I didn't push my last commit on this one. The one you merged does not specify the remote to fetch from so it will fetch all remotes. This is probably not a big deal, but I had specified the remote explicitly to be more consistent with the rest of the code. You can probably merge again. We tested with this last commit, not the first one. Thanks, Kris
Hide
Permalink
Adam Jacob added a comment -

I actually caught that in my code review, and should have said so when I closed the ticket.

Thanks for pointing it out, Kris.

Show
Adam Jacob added a comment - I actually caught that in my code review, and should have said so when I closed the ticket. Thanks for pointing it out, Kris.
Bryan McLellan [Opscode] made changes -
Component/s Providers [ 10005 ]
Bryan McLellan [Opscode] made changes -
Workflow jira [ 11397 ] New OSS [ 19053 ]
Bryan McLellan [Opscode] made changes -
Workflow New OSS [ 19053 ] OSS: Product Management [ 26961 ]
Transition Time In Source Status Execution Times Last Executer Last Execution Date
Open Open In Progress In Progress
7m 16s 1 Kris Rasmussen 09/Feb/10 9:59 PM
In Progress In Progress Resolved Resolved
5m 24s 1 Kris Rasmussen 09/Feb/10 10:04 PM
Resolved Resolved Closed Closed
2d 40m 1 Adam Jacob 11/Feb/10 10:45 PM

People

  • Assignee:
    Adam Jacob
    Reporter:
    Kris Rasmussen
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: