Non-integer cron hour causes cron entry to be matched incorrectly

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 0.7.16, 0.10.0
  • Fix Version/s: None
  • Component/s: Chef Client
  • Labels:
    None
  • Environment:

    Ubuntu 9.04, rhel 5.6

Description

Setting the cron resource's hour to something like "*/8" causes the cron to be added and deleted on alternating runs of chef-client. When added, chef-client will print "INFO: Added cron 'cron_name'" and when deleted will print "INFO: Updated cron 'cron_name'". Switching to an integer hour value (even when provided as a string) fixes the problem.

Bugged:

cron "bugged_cron" do
    user "root"
    hour "*/8"
    minute "0"
    command "/bin/true"
    action :create
  end

Working:

cron "working_cron" do
    user "root"
    hour "8"
    minute "0"
    command "/bin/true"
    action :create
  end

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. CHEF-3178 cron provider does not support month names and weekday names

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Lee Azzarello added a comment - - edited

Confirmed with chef-client and chef-server 0.8.4 for non-integer day-of-week as well. For example:

fail

cron "backup" do
  weekday "Sun"
  command "/usr/local/bin/pg_backup >> /var/log/pg_backup.log 2>&1"
end

success

cron "backup" do
  weekday "0"
  command "/usr/local/bin/pg_backup >> /var/log/pg_backup.log 2>&1"
end
Show
Lee Azzarello added a comment - - edited Confirmed with chef-client and chef-server 0.8.4 for non-integer day-of-week as well. For example: fail cron "backup" do weekday "Sun" command "/usr/local/bin/pg_backup >> / var /log/pg_backup.log 2>&1" end success cron "backup" do weekday "0" command "/usr/local/bin/pg_backup >> / var /log/pg_backup.log 2>&1" end
Hide
Permalink
Tollef Fog Heen added a comment - - edited

Seems to be fixed in 0.9:

: root@sacrifice (git)-[CHEF-939] ~/chef # ./chef/bin/chef-solo -j ~/chef.json -c ~/solo.rb
[Sat, 17 Jul 2010 11:12:33 +0200] INFO: Setting the run_list to ["resolver"] from JSON
[Sat, 17 Jul 2010 11:12:33 +0200] INFO: Starting Chef Run
[Sat, 17 Jul 2010 11:12:33 +0200] INFO: Added cron 'bugged_cron'
[Sat, 17 Jul 2010 11:12:33 +0200] INFO: Chef Run complete in 0.203195 seconds
[Sat, 17 Jul 2010 11:12:33 +0200] INFO: Running report handlers
[Sat, 17 Jul 2010 11:12:33 +0200] INFO: Report handlers complete
: root@sacrifice (git)-[CHEF-939] ~/chef # ./chef/bin/chef-solo -j ~/chef.json -c ~/solo.rb
[Sat, 17 Jul 2010 11:12:39 +0200] INFO: Setting the run_list to ["resolver"] from JSON
[Sat, 17 Jul 2010 11:12:39 +0200] INFO: Starting Chef Run
[Sat, 17 Jul 2010 11:12:39 +0200] INFO: Chef Run complete in 0.232316 seconds
[Sat, 17 Jul 2010 11:12:39 +0200] INFO: Running report handlers
[Sat, 17 Jul 2010 11:12:39 +0200] INFO: Report handlers complete
Show
Tollef Fog Heen added a comment - - edited Seems to be fixed in 0.9: : root@sacrifice (git)-[CHEF-939] ~/chef # ./chef/bin/chef-solo -j ~/chef.json -c ~/solo.rb [Sat, 17 Jul 2010 11:12:33 +0200] INFO: Setting the run_list to [ "resolver" ] from JSON [Sat, 17 Jul 2010 11:12:33 +0200] INFO: Starting Chef Run [Sat, 17 Jul 2010 11:12:33 +0200] INFO: Added cron 'bugged_cron' [Sat, 17 Jul 2010 11:12:33 +0200] INFO: Chef Run complete in 0.203195 seconds [Sat, 17 Jul 2010 11:12:33 +0200] INFO: Running report handlers [Sat, 17 Jul 2010 11:12:33 +0200] INFO: Report handlers complete : root@sacrifice (git)-[CHEF-939] ~/chef # ./chef/bin/chef-solo -j ~/chef.json -c ~/solo.rb [Sat, 17 Jul 2010 11:12:39 +0200] INFO: Setting the run_list to [ "resolver" ] from JSON [Sat, 17 Jul 2010 11:12:39 +0200] INFO: Starting Chef Run [Sat, 17 Jul 2010 11:12:39 +0200] INFO: Chef Run complete in 0.232316 seconds [Sat, 17 Jul 2010 11:12:39 +0200] INFO: Running report handlers [Sat, 17 Jul 2010 11:12:39 +0200] INFO: Report handlers complete
Hide
Permalink
KC Braunschweig added a comment - - edited

This appears to have regressed as it bit me in chef 0.10.0 with the same behavior described, i.e. alternating client runs add the crontab and then update it to nothing (i.e. delete).

Failing:

cron "rotate_oncall" do
  minute "0"
  hour "12"
  weekday "mon"
  mailto "kbraunschweig@edmunds.com"
  command "/deployments/oncall/oncall.pl --rotate"
  action :create
end

Working:

cron "rotate_oncall" do
  minute "0"
  hour "12"
  weekday "1"
  mailto "kbraunschweig@edmunds.com"
  command "/deployments/oncall/oncall.pl --rotate"
  action :create
end
      • NOTE the applicable field is "weekday" in my example.
Show
KC Braunschweig added a comment - - edited This appears to have regressed as it bit me in chef 0.10.0 with the same behavior described, i.e. alternating client runs add the crontab and then update it to nothing (i.e. delete). Failing: cron "rotate_oncall" do minute "0" hour "12" weekday "mon" mailto "kbraunschweig@edmunds.com" command "/deployments/oncall/oncall.pl --rotate" action :create end Working: cron "rotate_oncall" do minute "0" hour "12" weekday "1" mailto "kbraunschweig@edmunds.com" command "/deployments/oncall/oncall.pl --rotate" action :create end NOTE the applicable field is "weekday" in my example.
Hide
Permalink
KC Braunschweig added a comment -

see also: CHEF-3178

Show
KC Braunschweig added a comment - see also: CHEF-3178
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

CHEF-3178 has been merged to master and will be included in 10.14.0. Can someone test to see if it fixes this bug please?

Show
Bryan McLellan [Opscode] added a comment - CHEF-3178 has been merged to master and will be included in 10.14.0. Can someone test to see if it fixes this bug please?
Hide
Permalink
Xabier de Zuazo [Onddo Labs] added a comment -

I tested the last example:

cron "Failing rotate_oncall" do
  minute "0"
  hour "12"
  weekday "mon"
  mailto "kbraunschweig@edmunds.com"
  command "/deployments/oncall/oncall.pl --rotate # Failing"
  action :create
end

cron "Working rotate_oncall" do
  minute "0"
  hour "12"
  weekday "1"
  mailto "kbraunschweig@edmunds.com"
  command "/deployments/oncall/oncall.pl --rotate # Working"
  action :create
end

Fails in 10.12.0 and works well in 10.14.0.

I mark it as resolved.

Show
Xabier de Zuazo [Onddo Labs] added a comment - I tested the last example: cron "Failing rotate_oncall" do minute "0" hour "12" weekday "mon" mailto "kbraunschweig@edmunds.com" command "/deployments/oncall/oncall.pl --rotate # Failing" action :create end cron "Working rotate_oncall" do minute "0" hour "12" weekday "1" mailto "kbraunschweig@edmunds.com" command "/deployments/oncall/oncall.pl --rotate # Working" action :create end Fails in 10.12.0 and works well in 10.14.0. I mark it as resolved.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Closing again, reported fixed by CHEF-3178.

Show
Bryan McLellan [Opscode] added a comment - Closing again, reported fixed by CHEF-3178 .

People

  • Assignee:
    Unassigned
    Reporter:
    Garret Heaton
Vote (2)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: