Windows cookbook borks on Unix systems because of the Ruby 1.9 patches

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Component/s: windows
  • Labels:
    None
  • Environment:

    Chef 0.10.4, SLES 11

Description

The ruby_19_patches.rb unconditionally requires win32/open3 which is definitely not present on non-Windows systems. Thus, if that cookbook is merely present, even if it's not used everything breaks down unconditionally on Linux. However, the mere presence shouldn't break things. Valid use-cases are a simple checkout of git://github.com/opscode/cookbooks for a working basis or when using tools like Librarian which pull all requirements unconditionally.

Simply checking if we are on Windows before trying the patch solves the issue. A pull request is forthcoming.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. COOK-1142 Windows cookbook fails on non-windows platform.

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. COOK-1181 Windows cb blows up when included on non-win rubies

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. COOK-1237 Mysql cookbook downloads windows cookbook which causes issues on other systems

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. COOK-812 Monkey Patch CHEF-2684 causes popen4 to randomly fail on ruby 1.8

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. CHEF-2684 Windows Ruby 1.9: uninitialized constant Chef::Mixin::Command::Windows::Open4

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Holger Just added a comment -

Pull request is at https://github.com/opscode/cookbooks/pull/330

Show
Holger Just added a comment - Pull request is at https://github.com/opscode/cookbooks/pull/330
Hide
Permalink
jtimberman added a comment -

Marking resolved so this gets picked up for review.

Show
jtimberman added a comment - Marking resolved so this gets picked up for review.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Seth, with CHEF-2684, and shellout being the way things are, do we still need this patch?

Show
Bryan McLellan [Opscode] added a comment - Seth, with CHEF-2684 , and shellout being the way things are, do we still need this patch?
Hide
Permalink
Mike Javorski added a comment - - edited

While I personally can't speak to CHEF-2684, as long as the windows cookbook is pulled in by the chef-client recipes, it kills chef-client on all of my Ubuntu based machines. I've patched my cookbook in place, but certainly there are others effected.

Show
Mike Javorski added a comment - - edited While I personally can't speak to CHEF-2684 , as long as the windows cookbook is pulled in by the chef-client recipes, it kills chef-client on all of my Ubuntu based machines. I've patched my cookbook in place, but certainly there are others effected.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

This was reviewed and marked to be merged. Thanks!

Show
Bryan McLellan [Opscode] added a comment - This was reviewed and marked to be merged. Thanks!
Hide
Permalink
jtimberman added a comment -

We have moved the windows cookbook to a new repository per a recent blog post. This patch is now merged into the new repository.

The new repository is here:

https://github.com/opscode-cookbooks/windows

Thank you!

Show
jtimberman added a comment - We have moved the windows cookbook to a new repository per a recent blog post. This patch is now merged into the new repository. The new repository is here: https://github.com/opscode-cookbooks/windows Thank you!
Hide
Permalink
jtimberman added a comment -

The file in question, libraries/ruby_19_patches.rb is no longer required in Chef 0.10.6+, per CHEF-2684 being resolved. As this version or later is what we ship in the "official" Chef MSI (http://opscode.com/chef/install), I have removed the file entirely from the cookbook and pushed to https://github.com/opscode-cookbooks/windows. We'll release a new version shortly.

This also should resolve COOK-812, COOK-1237 (indirectly), and COOK-1181.

Show
jtimberman added a comment - The file in question, libraries/ruby_19_patches.rb is no longer required in Chef 0.10.6+, per CHEF-2684 being resolved. As this version or later is what we ship in the "official" Chef MSI ( http://opscode.com/chef/install ), I have removed the file entirely from the cookbook and pushed to https://github.com/opscode-cookbooks/windows . We'll release a new version shortly. This also should resolve COOK-812 , COOK-1237 (indirectly), and COOK-1181 .
Hide
Permalink
jtimberman added a comment -

Released in windows v1.3.2

Show
jtimberman added a comment - Released in windows v1.3.2

People

  • Assignee:
    jtimberman
    Reporter:
    Holger Just
Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: