teach python_pip about requirements files.

Details

  • Type: New Feature New Feature
  • Status: Reopened Reopened
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Component/s: python
  • Labels:

Description

The python_pip provider should be able to use a requirements file to install a set of packages for an application. Currently in the application::django recipe we instead use an execute, which is not nearly as awesome.

  1. Text File
    chef-run.log
    25/Oct/12 8:56 PM
    4 kB
    Saager Mhatre
  2. File
    python_pip_install_requirements_test_env.tgz
    25/Oct/12 8:56 PM
    0.8 kB
    Saager Mhatre

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
jtimberman added a comment -

Pull request here:

https://github.com/opscode/cookbooks/pull/365

Against the old monolithic repository. I don't see a PR from Sivy on the new repository.

Show
jtimberman added a comment - Pull request here: https://github.com/opscode/cookbooks/pull/365 Against the old monolithic repository. I don't see a PR from Sivy on the new repository.
Hide
Permalink
jtimberman added a comment -

Rebasing the pull request branch vs opscode/cookbooks master failed.

Show
jtimberman added a comment - Rebasing the pull request branch vs opscode/cookbooks master failed.
Hide
Permalink
Saager Mhatre added a comment -

An alternative to this would be to add an install_requirements action. I'll try to whip up some code and put in a Pull Request.

Show
Saager Mhatre added a comment - An alternative to this would be to add an install_requirements action. I'll try to whip up some code and put in a Pull Request.
Hide
Permalink
Saager Mhatre added a comment - - edited

Pull request here: https://github.com/opscode-cookbooks/python/pull/2010

Associated run log and test environment attached.

Show
Saager Mhatre added a comment - - edited Pull request here: https://github.com/opscode-cookbooks/python/pull/2010 Associated run log and test environment attached.
Hide
Permalink
Saager Mhatre added a comment -

There has been some debate about this between Noah Kantrowitz and myself on the pull request. I was hoping more members of the community would contribute their views to it.

Thanks

Show
Saager Mhatre added a comment - There has been some debate about this between Noah Kantrowitz and myself on the pull request . I was hoping more members of the community would contribute their views to it. Thanks
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Today's code review group has consensus, we'd prefer to see this as a separate resource.

If you want to discuss it further, the [chef-dev|lists.opscode.com/sympa/info/chef-dev] mailing list would be appropriate.

However, this action doesn't install the package in question, instead we're just installing the dependencies related to that package. While we're still working with packages here, this is a different pattern than just installing a package, possibly along with dependencies. That's what makes it different.

In other words, each resource should manage something specific. A package resource manages a package. Here we're managing the dependencies of a package, which I don't think is the same thing.

Show
Bryan McLellan [Opscode] added a comment - Today's code review group has consensus, we'd prefer to see this as a separate resource. If you want to discuss it further, the [chef-dev|lists.opscode.com/sympa/info/chef-dev] mailing list would be appropriate. However, this action doesn't install the package in question, instead we're just installing the dependencies related to that package. While we're still working with packages here, this is a different pattern than just installing a package, possibly along with dependencies. That's what makes it different. In other words, each resource should manage something specific. A package resource manages a package. Here we're managing the dependencies of a package, which I don't think is the same thing.
Hide
Permalink
Cameron Johnston added a comment -

I've implemented a python_pip_requirements LWRP, pull request here https://github.com/opscode-cookbooks/python/pull/27

Show
Cameron Johnston added a comment - I've implemented a python_pip_requirements LWRP, pull request here https://github.com/opscode-cookbooks/python/pull/27
Hide
Permalink
Steven Danna added a comment -

See Noah's comments on github.

Show
Steven Danna added a comment - See Noah's comments on github.
Hide
Permalink
Peter Norton added a comment -

What was the reason for code review wanting this as a separate LWRP?

Show
Peter Norton added a comment - What was the reason for code review wanting this as a separate LWRP?

People

  • Assignee:
    Saager Mhatre
    Reporter:
    jtimberman
Vote (3)
Watch (6)

Dates

  • Created:
    Updated:
    Resolved: