Support for PECL zend extensions, and better file name handling.

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Component/s: php
  • Labels:

Description

The pecl (pear) provider assumes all extensions are of the form package_name.so, which is not always the case.
Also it has no support for extensions which must be loaded by the zend extension loader.

I've fixed this in my branch: https://github.com/leth/cookbooks/tree/pecl-zend

I'm pretty new with ruby, so any coding style/idiom suggestions would be welcome.

Thanks,

P.S. Pull request incoming.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Marcus Cobden added a comment -

Here you go: https://github.com/opscode/cookbooks/pull/359

Show
Marcus Cobden added a comment - Here you go: https://github.com/opscode/cookbooks/pull/359
Marcus Cobden made changes -
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

1) The resource should have the zend_extensions attribute added to it as well with a reasonable default value.

2) What is Set['xdebug.so']? Is this a working example?

# install the xdebug pecl
    php_pear "xdebug" do
      zend_extensions Set['xdebug.so']
      action :install
    end

3) You should indent your blocks so it is more obvious they're blocks, see below this line:

extensions = Hash[ files.map { |filepath|
Show
Bryan McLellan [Opscode] added a comment - 1) The resource should have the zend_extensions attribute added to it as well with a reasonable default value. 2) What is Set ['xdebug.so'] ? Is this a working example? # install the xdebug pecl php_pear "xdebug" do zend_extensions Set['xdebug.so'] action :install end 3) You should indent your blocks so it is more obvious they're blocks, see below this line: extensions = Hash[ files.map { |filepath|
Bryan McLellan [Opscode] made changes -
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Hide
Permalink
Marcus Cobden added a comment -

1) Whoops, I suspect I forgot to add the changes to that file.

2) I'll comment this, and change it to expect an array, rather than a set, since it's not going to be a real performance problem.

3) Thanks. I don't know why I missed that.

I'll get to work on this on monday!

Show
Marcus Cobden added a comment - 1) Whoops, I suspect I forgot to add the changes to that file. 2) I'll comment this, and change it to expect an array, rather than a set, since it's not going to be a real performance problem. 3) Thanks. I don't know why I missed that. I'll get to work on this on monday!
Hide
Permalink
Marcus Cobden added a comment -

I've updated the pull request.

Show
Marcus Cobden added a comment - I've updated the pull request.
Hide
Permalink
Marcus Cobden added a comment -

I've made the changes suggested.

Show
Marcus Cobden added a comment - I've made the changes suggested.
Marcus Cobden made changes -
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Looks good, marked to be merged.

Show
Bryan McLellan [Opscode] added a comment - Looks good, marked to be merged.
Bryan McLellan [Opscode] made changes -
Triage Status [Triaged]
Hide
Permalink
jtimberman added a comment -

This is merged in the new php repository, https://github.com/opscode-cookbooks/php and will be included in the next release. Thank you!

Show
jtimberman added a comment - This is merged in the new php repository, https://github.com/opscode-cookbooks/php and will be included in the next release. Thank you!
jtimberman made changes -
Merge Status [Merged]
Hide
Permalink
Marcus Cobden added a comment -

Sorry, I failed to include the changes to the template file.

Show
Marcus Cobden added a comment - Sorry, I failed to include the changes to the template file.
Marcus Cobden made changes -
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Assignee Marcus Cobden [ leth ]
Merge Status [Merged]
Hide
Permalink
Marcus Cobden added a comment -

I've opened another pull request against the new repository.
Sorry about that!

https://github.com/opscode-cookbooks/php/pull/3

Show
Marcus Cobden added a comment - I've opened another pull request against the new repository. Sorry about that! https://github.com/opscode-cookbooks/php/pull/3
Marcus Cobden made changes -
Status Reopened [ 4 ] Resolved [ 5 ]
Assignee Marcus Cobden [ leth ]
Resolution Fixed [ 1 ]
Hide
Permalink
jtimberman added a comment -

Ah, thanks for catching that Marcus. I merged that pull request. Cheers!

Show
jtimberman added a comment - Ah, thanks for catching that Marcus. I merged that pull request. Cheers!
jtimberman made changes -
Merge Status [Merged]
Hide
Permalink
jtimberman added a comment -

Released in v1.1.0

Show
jtimberman added a comment - Released in v1.1.0
jtimberman made changes -
Status Resolved [ 5 ] Closed [ 6 ]
jtimberman made changes -
Workflow jira [ 15315 ] New OSS [ 22268 ]
Transition Time In Source Status Execution Times Last Executer Last Execution Date
Open Open Resolved Resolved
10d 21h 9m 1 Marcus Cobden 13/Mar/12 9:56 AM
Resolved Resolved Reopened Reopened
14d 2h 14m 2 Marcus Cobden 13/Apr/12 7:41 AM
Reopened Reopened Resolved Resolved
17d 11h 38m 2 Marcus Cobden 13/Apr/12 11:49 PM
Resolved Resolved Closed Closed
139d 3h 51m 1 jtimberman 31/Aug/12 3:41 AM

People

  • Assignee:
    Unassigned
    Reporter:
    Marcus Cobden
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: