nginx default site should not always be enabled

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Component/s: nginx
  • Labels:
  • Environment:

    nginx 0.101.2

Description

Similar to the report in COOK-1315, nginx default site should be configurable to a san default, but allow override .

Location: recipes/commons.rb

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. COOK-1257 apache2 and munin defaults fight over apache default site, cause needless restarts

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. COOK-1315 apache2 default should allow the default site to not be enabled

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mike Fiedler added a comment - - edited

Pull here: https://github.com/opscode-cookbooks/nginx/pull/10

Show
Mike Fiedler added a comment - - edited Pull here: https://github.com/opscode-cookbooks/nginx/pull/10
Hide
Permalink
jtimberman added a comment -

Commented on the pull request:

This cannot be automatically merged, indicating a conflict. Can you rebase w/ master and reapply your patch and update the pull request? Thanks!

Show
jtimberman added a comment - Commented on the pull request: This cannot be automatically merged, indicating a conflict. Can you rebase w/ master and reapply your patch and update the pull request? Thanks!
Hide
Permalink
Mike Fiedler added a comment -

Updated, fixing conflicts.

Show
Mike Fiedler added a comment - Updated, fixing conflicts.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Reviewed and marked for merge.

Show
Bryan McLellan [Opscode] added a comment - Reviewed and marked for merge.
Hide
Permalink
jtimberman added a comment -

Thanks Mike, this is merged.

Show
jtimberman added a comment - Thanks Mike, this is merged.
Hide
Permalink
jtimberman added a comment -

Released in v1.0.0

Show
jtimberman added a comment - Released in v1.0.0

People

  • Assignee:
    Mike Fiedler
    Reporter:
    Mike Fiedler
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: