python_pip resource breaks when installing a brand new package

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Component/s: python
  • Labels:

Description

Caused by:
In recipe:
python_pip 'redis'

chef-client version is 0.10.10

Chef-client Debug output:
[Fri, 25 May 2012 03:09:32 +0000] FATAL: Stacktrace dumped to /var/cache/chef/chef-stacktrace.out
[Fri, 25 May 2012 03:09:32 +0000] DEBUG: Mixlib::ShellOut::ShellCommandFailed: python_pip[redis] (nagios::client line 26) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '1'
---- Begin output of pip freeze | grep -i '^redis==' ----
STDOUT:
STDERR:
---- End output of pip freeze | grep -i '^redis==' ----
Ran pip freeze | grep -i '^redis==' returned 1
/usr/lib/ruby/vendor_ruby/mixlib/shellout.rb:242:in `invalid!'
/usr/lib/ruby/vendor_ruby/mixlib/shellout.rb:228:in `error!'
/usr/lib/ruby/vendor_ruby/chef/mixin/shell_out.rb:36:in `shell_out!'
/var/cache/chef/cookbooks/python/providers/pip.rb:127:in `current_installed_version'
/var/cache/chef/cookbooks/python/providers/pip.rb:110:in `load_current_resource'
/usr/lib/ruby/vendor_ruby/chef/resource.rb:453:in `run_action'
/usr/lib/ruby/vendor_ruby/chef/runner.rb:49:in `run_action'
/usr/lib/ruby/vendor_ruby/chef/runner.rb:85:in `converge'
/usr/lib/ruby/vendor_ruby/chef/runner.rb:85:in `each'
/usr/lib/ruby/vendor_ruby/chef/runner.rb:85:in `converge'
/usr/lib/ruby/vendor_ruby/chef/resource_collection.rb:94:in `execute_each_resource'
/usr/lib/ruby/vendor_ruby/chef/resource_collection/stepable_iterator.rb:116:in `call'
/usr/lib/ruby/vendor_ruby/chef/resource_collection/stepable_iterator.rb:116:in `call_iterator_block'
/usr/lib/ruby/vendor_ruby/chef/resource_collection/stepable_iterator.rb:85:in `step'
/usr/lib/ruby/vendor_ruby/chef/resource_collection/stepable_iterator.rb:104:in `iterate'
/usr/lib/ruby/vendor_ruby/chef/resource_collection/stepable_iterator.rb:55:in `each_with_index'
/usr/lib/ruby/vendor_ruby/chef/resource_collection.rb:92:in `execute_each_resource'
/usr/lib/ruby/vendor_ruby/chef/runner.rb:80:in `converge'
/usr/lib/ruby/vendor_ruby/chef/client.rb:330:in `converge'
/usr/lib/ruby/vendor_ruby/chef/client.rb:163:in `run'
/usr/lib/ruby/vendor_ruby/chef/application/client.rb:254:in `run_application'
/usr/lib/ruby/vendor_ruby/chef/application/client.rb:241:in `loop'
/usr/lib/ruby/vendor_ruby/chef/application/client.rb:241:in `run_application'
/usr/lib/ruby/vendor_ruby/chef/application.rb:70:in `run'
/usr/bin/chef-client:25
[Fri, 25 May 2012 03:09:32 +0000] FATAL: Mixlib::ShellOut::ShellCommandFailed: python_pip[redis] (nagios::client line 26) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '1'
---- Begin output of pip freeze | grep -i '^redis==' ----
STDOUT:
STDERR:
---- End output of pip freeze | grep -i '^redis==' ----
Ran pip freeze | grep -i '^redis==' returned 1

Issue Links

duplicates

Bug - A problem which impairs or prevents the functions of the product. COOK-1282 Python pip provider rescues incorrect error.

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
is duplicated by

Bug - A problem which impairs or prevents the functions of the product. COOK-1472 python_pip[virtualenv] fails in chef 10.12.0

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Reopened - This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Viral Shah added a comment -

please pull:
https://github.com/viralshah/python/tree/COOK-1320

pull request is here:
https://github.com/opscode-cookbooks/python/pull/12

Show
Viral Shah added a comment - please pull: https://github.com/viralshah/python/tree/COOK-1320 pull request is here: https://github.com/opscode-cookbooks/python/pull/12
Hide
Permalink
Hector Castro added a comment -

Confirmed that this works – thanks, Viral.

Show
Hector Castro added a comment - Confirmed that this works – thanks, Viral.
Hide
Permalink
jtimberman added a comment -

I'm marking this as untriaged so it gets picked up during an Opscode code review / triage meeting.

Show
jtimberman added a comment - I'm marking this as untriaged so it gets picked up during an Opscode code review / triage meeting.
Hide
Permalink
Viral Shah added a comment -

you might also want to fix a similar case in the php cookbook. I hesitate to do it myself since I don't have means to test it.

Show
Viral Shah added a comment - you might also want to fix a similar case in the php cookbook. I hesitate to do it myself since I don't have means to test it.
Hide
Permalink
Viral Shah added a comment -

I also noticed that this change is not compatible with chef-0.10.8
But I am not sure how to make it so that it is, my ruby knowledge is limited.

Show
Viral Shah added a comment - I also noticed that this change is not compatible with chef-0.10.8 But I am not sure how to make it so that it is, my ruby knowledge is limited.
Hide
Permalink
jtimberman added a comment -

This is now merged and will be in the next cookbook version. Thanks!

Show
jtimberman added a comment - This is now merged and will be in the next cookbook version. Thanks!
Hide
Permalink
Quentin Hartman added a comment - - edited

I ran into a similar problem, but during the initial run of the python::default recipe. It installs pip, then attempts to install virtualenv using the python_pip provider, but breaks because virtualenv is not installed. This worked fine under chef 0.10.0, but broke under 10.12. The above changes from Viral Shah did not work for me. Here is the patch against 1.0.6 that did the trick:

--- /home/qhartman/foo/python/providers/pip.rb
+++ /home/qhartman/chef-repo/cookbooks/python/providers/pip.rb
@@ -124,8 +124,10 @@
       delimeter = /\s/
       version_check_cmd = "pip --version"
     end
-    p = shell_out!(version_check_cmd)
-    p.stdout.split(delimeter)[1].strip
+    p = shell_out(version_check_cmd)
+    unless p.stdout.split(delimeter).count < 2
+      p.stdout.split(delimeter)[1].strip
+    end
   rescue Chef::Exceptions::ShellCommandFailed
   end
 end
Show
Quentin Hartman added a comment - - edited I ran into a similar problem, but during the initial run of the python::default recipe. It installs pip, then attempts to install virtualenv using the python_pip provider, but breaks because virtualenv is not installed. This worked fine under chef 0.10.0, but broke under 10.12. The above changes from Viral Shah did not work for me. Here is the patch against 1.0.6 that did the trick: --- /home/qhartman/foo/python/providers/pip.rb +++ /home/qhartman/chef-repo/cookbooks/python/providers/pip.rb @@ -124,8 +124,10 @@ delimeter = /\s/ version_check_cmd = "pip --version" end - p = shell_out!(version_check_cmd) - p.stdout.split(delimeter)[1].strip + p = shell_out(version_check_cmd) + unless p.stdout.split(delimeter).count < 2 + p.stdout.split(delimeter)[1].strip + end rescue Chef::Exceptions::ShellCommandFailed end end
Hide
Permalink
Michael Johnston added a comment -

I had the same problem as Quentin Hartman and his patch worked for me. I added http://tickets.opscode.com/browse/COOK-1472 as a separate issue, and a pull request https://github.com/opscode-cookbooks/python/pull/16

Show
Michael Johnston added a comment - I had the same problem as Quentin Hartman and his patch worked for me. I added http://tickets.opscode.com/browse/COOK-1472 as a separate issue, and a pull request https://github.com/opscode-cookbooks/python/pull/16
Hide
Permalink
jtimberman added a comment -

Released in python cookbook v1.0.8. Thanks!

Show
jtimberman added a comment - Released in python cookbook v1.0.8. Thanks!

People

  • Assignee:
    Viral Shah
    Reporter:
    Viral Shah
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: