Convert runit_service definition to a service resource named runit_service

I would like to see this as well. Perhaps it could have the service directory as an attribute. Ideally I would like to use this with notifies in the same way I do for init based services.

One option here would be to use an LWRP in the runit cookbook.

Initial pass here, https://github.com/jtimberman/cookbooks/tree/CHEF-154/runit

Use runit_service to get the LWRP. The definition is still available but named runit_svc. A number of the parameters supported by the definition aren't implemented in the LWRP.

We should incorporate changes introduced by these pull requests:

• https://github.com/opscode/cookbooks/pull/161
• https://github.com/opscode/cookbooks/pull/162

There is a bug in the proposed runit_service. The use of "execute" resources in the actions in the provider mean that the specified commands will not actually run during a notification stage because of the timing of when "execute" resources actually run by default.

For example, if the runit_service ":restart" action is specified in a recipe, the "execute" resource that actually restarts the service will have its ":run" action invoked during the converge phase and everything works as intended.

However, if :restart is invoked as a notification, there is no subsequent convergence phase to call :run on the execute resource. Instead, execute needs to be called just like a compile-phase execution resource would (effectively, a "notification-phase execution") or it needs to be replaced with a synchronous run_command_with_systems_locale() command or equivalent.

I've put in a pull request with fixes: https://github.com/jtimberman/cookbooks/pull/3

Hi David,

I apologize for the delay in responding. I don't normally look at the pull requests on my fork of the Opscode cookbooks. Two important changes have occurred since you opened the pull request:

• Opscode cookbooks are now https://github.com/opscode-cookbooks, including the [runit cookbook](https://github.com/opscode-cookbooks/runit).
• I started working on the CHEF-154 ticket again, and am doing so under [my fork] (https://github.com/jtimberman/runit/tree/CHEF-154)

Due to the changes I've made in my branch, your patch didn't merge cleanly. However, I went ahead and made the changes and pushed to my branch. Thank you for noticing this issue, and for opening the pull request with this patch, and for follow-up on the Jira ticket.

I'm going to close this pull request. If you have further changes for the runit cookbook, see the new repository here:

• https://github.com/opscode-cookbooks/runit

Thanks!

We'll need to make sure that the README documents how a user can use the new resource to write logs somewhere that an alternate user can access, per this pull request:

https://github.com/opscode/cookbooks/pull/162

I've submitted a new pull request against the CHEF-154 branch in jtimberman:

https://github.com/jtimberman/runit/pull/1

It restores important functionality that was removed.

Also, the runit cookbook version number needs to be bumped in metadata.rb. I suggest 1.0.0, to signify the major break from the definition based 0.X.Y series.

Seems like this could benefit from Noah's desire to have LWRPs 'subclass' from other RPs. Does anyone know what the ticket for that is?

Epic amount of work in this branch:

https://github.com/opscode-cookbooks/runit/tree/CHEF-154

The LWRP is now a full Ruby class resource/provider like those found in Chef, with unit tests in rspec (test/spec, run "rake spec"). There's test-kitchen support, and a runit_test cookbook with a "service" configuration that can be used to do integration test of various scenarios.

The "runit_service" definition is completely removed. One thing that is lost with this is the "service" resource that the runit_service definition set up for notification purposes is gone. This means that if you have services that are set up with runit and you notify them to restart, you'd need to update the notifications to use the runit_service resource, e.g.:

template "/etc/conffile.conf" do
  notifies :restart, "runit_service[myservice]"
end

The branch is updated and pending README update to cover the changes and usage. It also includes COOK-2164 - RH platform family support (thanks Paul Graydon!). The code all passes the tests, so I am marking this as "fix provided."

CHEF-154 is now COOK-2254 (and I'm amused that the ticket still ends in "54").

Mailing list post describing the changes (and what's breaking, etc):

http://lists.opscode.com/sympa/arc/chef/2013-01/msg00319.html

And there it is:

https://github.com/opscode-cookbooks/runit/pull/11

We need to pin the cookbooks mentioned in COOK-2253 to runit <= 0.16.2 in their metadata until each cookbook is updated to use this resource.

This is merged to master.

We have some updates to add that may allow for better backwards compatibility that don't require users to change their existing recipes, so we're going to delay the 1.0 release.

Use the previous version, 0.16.2 (there's a git tag on the repository, and the cookbook is released at that version on the community site). Do not use master unless you want to help test.

Released in v1.0.0.