Allow configuration of path to chef-client binary in init script

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Component/s: chef-client
  • Environment:

    Redhat and all variants (CentOS, OEL)

Description

On line 21 of the chef-client init script for redhat variants, the path to chef-client as installed by gems is wrong.

It currently reads:
exec="/usr/bin/chef-client"
The correct path is:
exec="/usr/local/bin/chef-client"

Due to this, the daemon never attempts to start because of the test on line 35:
[ -x $exec ] || exit 5

But even with this corrected, the script still won't work without a few further changes.

Line 38 reads:
daemon chef-client -d -c "$config" -L "$logfile" -P "$pidfile" -i "$interval" -s "$splay" "$options"
This should be:
daemon $exec -d -c "$config" -L "$logfile" -P "$pidfile" -i "$interval" -s "$splay" "$options"

Line 47 reads:
killproc -p $pidfile chef-client
This should be:
killproc -p $pidfile $exec

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. COOK-1359 chef-client init script does not invoke "daemon" with full path

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Johnson added a comment -

Patched in https://github.com/charlesjohnson/chef/tree/4d77b42f6e597070d7cf0dded56f4b078031dd4d

Show
Charles Johnson added a comment - Patched in https://github.com/charlesjohnson/chef/tree/4d77b42f6e597070d7cf0dded56f4b078031dd4d
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

We had put the init scripts in the gem and had the chef-client cookbook pull them from there to avoid duplication between distribution packaging and the chef-client cookbook. We've decided this isn't working out so well, so we're going to place templatized init scripts in the chef-client cookbook. Accordingly, I've moved this ticket to the COOK project and I'm renaming it to track that progress. Part of the problem is that depending on how you install Rubygems on Redhat, your binaries could be in /usr/bin/, /usr/local/bin/, or somewhere else, so we're going to make that configurable.

Show
Bryan McLellan [Opscode] added a comment - We had put the init scripts in the gem and had the chef-client cookbook pull them from there to avoid duplication between distribution packaging and the chef-client cookbook. We've decided this isn't working out so well, so we're going to place templatized init scripts in the chef-client cookbook. Accordingly, I've moved this ticket to the COOK project and I'm renaming it to track that progress. Part of the problem is that depending on how you install Rubygems on Redhat, your binaries could be in /usr/bin/, /usr/local/bin/, or somewhere else, so we're going to make that configurable.
Hide
Permalink
Seth Chisamore added a comment - - edited

Semi-related tickets:
COOK-204
COOK-491
COOK-525
COOK-554
COOK-599
COOK-609
COOK-635

Plan on fixing all when I refactor the chef-client cookbook 'soonish'.

Show
Seth Chisamore added a comment - - edited Semi-related tickets: COOK-204 COOK-491 COOK-525 COOK-554 COOK-599 COOK-609 COOK-635 Plan on fixing all when I refactor the chef-client cookbook 'soonish'.
Hide
Permalink
Seth Chisamore added a comment -

This has been fixed/merged:
https://github.com/opscode/cookbooks/commit/1a97c007a0af1cadd2bbcc1486955d50302174b6

Released to the community site as v1.0.0

Show
Seth Chisamore added a comment - This has been fixed/merged: https://github.com/opscode/cookbooks/commit/1a97c007a0af1cadd2bbcc1486955d50302174b6 Released to the community site as v1.0.0
Hide
Permalink
Sean Escriva added a comment -

Looks like this was accidentally reverted: https://github.com/opscode-cookbooks/chef-client/commit/5aacab123ba1dc9c50efb2a422d56803342dc685#templates/default/redhat/init.d/chef-client.erb

Show
Sean Escriva added a comment - Looks like this was accidentally reverted: https://github.com/opscode-cookbooks/chef-client/commit/5aacab123ba1dc9c50efb2a422d56803342dc685#templates/default/redhat/init.d/chef-client.erb
Hide
Permalink
Sean Escriva added a comment -

looks like this was change was maybe reverted by mistake

Show
Sean Escriva added a comment - looks like this was change was maybe reverted by mistake
Hide
Permalink
Mike Fiedler added a comment -

This is a minor fix to the previous issue, where the (correct) code that was committed was clobbered by someone else.

https://github.com/opscode-cookbooks/chef-client/pull/33

Show
Mike Fiedler added a comment - This is a minor fix to the previous issue, where the (correct) code that was committed was clobbered by someone else. https://github.com/opscode-cookbooks/chef-client/pull/33
Hide
Permalink
Joshua Timberman [Opscode] added a comment -

Thanks Mike!

Show
Joshua Timberman [Opscode] added a comment - Thanks Mike!
Hide
Permalink
Joshua Timberman [Opscode] added a comment -

Transitioning this ticket to "Fix Committed" to reflect new workflow state where a ticket's contribution is merged into the master branch, but hasn't been released in a new version yet.

Show
Joshua Timberman [Opscode] added a comment - Transitioning this ticket to "Fix Committed" to reflect new workflow state where a ticket's contribution is merged into the master branch, but hasn't been released in a new version yet.
Hide
Permalink
Joshua Timberman [Opscode] added a comment -

Released in v2.0.0

Show
Joshua Timberman [Opscode] added a comment - Released in v2.0.0

People

  • Assignee:
    Mike Fiedler
    Reporter:
    Charles Johnson
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: