Allow configuration of path to chef-client binary in init script

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Component/s: chef-client
  • Environment:

    Redhat and all variants (CentOS, OEL)

Description

On line 21 of the chef-client init script for redhat variants, the path to chef-client as installed by gems is wrong.

It currently reads:
exec="/usr/bin/chef-client"
The correct path is:
exec="/usr/local/bin/chef-client"

Due to this, the daemon never attempts to start because of the test on line 35:
[ -x $exec ] || exit 5

But even with this corrected, the script still won't work without a few further changes.

Line 38 reads:
daemon chef-client -d -c "$config" -L "$logfile" -P "$pidfile" -i "$interval" -s "$splay" "$options"
This should be:
daemon $exec -d -c "$config" -L "$logfile" -P "$pidfile" -i "$interval" -s "$splay" "$options"

Line 47 reads:
killproc -p $pidfile chef-client
This should be:
killproc -p $pidfile $exec

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. COOK-1359 chef-client init script does not invoke "daemon" with full path

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Johnson added a comment -

Patched in https://github.com/charlesjohnson/chef/tree/4d77b42f6e597070d7cf0dded56f4b078031dd4d

Show
Charles Johnson added a comment - Patched in https://github.com/charlesjohnson/chef/tree/4d77b42f6e597070d7cf0dded56f4b078031dd4d
Charles Johnson made changes -
Field Original Value New Value
Assignee Charles Johnson [ mr_chip ]
Charles Johnson made changes -
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Bryan McLellan [Opscode] made changes -
Project Chef [ 10000 ] Chef Cookbooks [ 10010 ]
Key CHEF-2400 COOK-635
Issue Type Bug [ 1 ] Improvement [ 4 ]
Affects Version/s 0.10.0 [ 10081 ]
Component/s chef-client [ 10101 ]
Component/s Chef Client [ 10000 ]
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

We had put the init scripts in the gem and had the chef-client cookbook pull them from there to avoid duplication between distribution packaging and the chef-client cookbook. We've decided this isn't working out so well, so we're going to place templatized init scripts in the chef-client cookbook. Accordingly, I've moved this ticket to the COOK project and I'm renaming it to track that progress. Part of the problem is that depending on how you install Rubygems on Redhat, your binaries could be in /usr/bin/, /usr/local/bin/, or somewhere else, so we're going to make that configurable.

Show
Bryan McLellan [Opscode] added a comment - We had put the init scripts in the gem and had the chef-client cookbook pull them from there to avoid duplication between distribution packaging and the chef-client cookbook. We've decided this isn't working out so well, so we're going to place templatized init scripts in the chef-client cookbook. Accordingly, I've moved this ticket to the COOK project and I'm renaming it to track that progress. Part of the problem is that depending on how you install Rubygems on Redhat, your binaries could be in /usr/bin/, /usr/local/bin/, or somewhere else, so we're going to make that configurable.
Bryan McLellan [Opscode] made changes -
Summary Init script for redhat/centos will not start daemon Allow configuration of path to chef-client binary in init script
Bryan McLellan [Opscode] made changes -
Assignee Charles Johnson [ mr_chip ]
Hide
Permalink
Seth Chisamore added a comment - - edited

Semi-related tickets:
COOK-204
COOK-491
COOK-525
COOK-554
COOK-599
COOK-609
COOK-635

Plan on fixing all when I refactor the chef-client cookbook 'soonish'.

Show
Seth Chisamore added a comment - - edited Semi-related tickets: COOK-204 COOK-491 COOK-525 COOK-554 COOK-599 COOK-609 COOK-635 Plan on fixing all when I refactor the chef-client cookbook 'soonish'.
Seth Chisamore made changes -
Assignee Seth Chisamore [ schisamo ]
Hide
Permalink
Seth Chisamore added a comment -

This has been fixed/merged:
https://github.com/opscode/cookbooks/commit/1a97c007a0af1cadd2bbcc1486955d50302174b6

Released to the community site as v1.0.0

Show
Seth Chisamore added a comment - This has been fixed/merged: https://github.com/opscode/cookbooks/commit/1a97c007a0af1cadd2bbcc1486955d50302174b6 Released to the community site as v1.0.0
Seth Chisamore made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Triage Status [Triaged]
Hide
Permalink
Sean Escriva added a comment -

Looks like this was accidentally reverted: https://github.com/opscode-cookbooks/chef-client/commit/5aacab123ba1dc9c50efb2a422d56803342dc685#templates/default/redhat/init.d/chef-client.erb

Show
Sean Escriva added a comment - Looks like this was accidentally reverted: https://github.com/opscode-cookbooks/chef-client/commit/5aacab123ba1dc9c50efb2a422d56803342dc685#templates/default/redhat/init.d/chef-client.erb
Hide
Permalink
Sean Escriva added a comment -

looks like this was change was maybe reverted by mistake

Show
Sean Escriva added a comment - looks like this was change was maybe reverted by mistake
Sean Escriva made changes -
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Mike Fiedler made changes -
Assignee Seth Chisamore [ schisamo ] Mike Fiedler [ miketheman ]
Hide
Permalink
Mike Fiedler added a comment -

This is a minor fix to the previous issue, where the (correct) code that was committed was clobbered by someone else.

https://github.com/opscode-cookbooks/chef-client/pull/33

Show
Mike Fiedler added a comment - This is a minor fix to the previous issue, where the (correct) code that was committed was clobbered by someone else. https://github.com/opscode-cookbooks/chef-client/pull/33
Mike Fiedler made changes -
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Mike Fiedler made changes -
Link This issue is duplicated by COOK-1359 [ COOK-1359 ]
Hide
Permalink
jtimberman added a comment -

Thanks Mike!

Show
jtimberman added a comment - Thanks Mike!
jtimberman made changes -
Merge Status [Merged]
jtimberman made changes -
Workflow jira [ 13580 ] New OSS [ 21136 ]
Status Resolved [ 5 ] Fix Provided [ 10002 ]
jtimberman made changes -
Status Fix Provided [ 10002 ] Fix Reviewed [ 10000 ]
Hide
Permalink
jtimberman added a comment -

Transitioning this ticket to "Fix Committed" to reflect new workflow state where a ticket's contribution is merged into the master branch, but hasn't been released in a new version yet.

Show
jtimberman added a comment - Transitioning this ticket to "Fix Committed" to reflect new workflow state where a ticket's contribution is merged into the master branch, but hasn't been released in a new version yet.
jtimberman made changes -
Status Fix Reviewed [ 10000 ] Fix Committed [ 10003 ]
Hide
Permalink
jtimberman added a comment -

Released in v2.0.0

Show
jtimberman added a comment - Released in v2.0.0
jtimberman made changes -
Status Fix Committed [ 10003 ] Closed [ 6 ]
Transition Time In Source Status Execution Times Last Executer Last Execution Date
Open Open Resolved Resolved
2h 13m 1 Charles Johnson 02/Jun/11 9:08 PM
Resolved Resolved Closed Closed
47d 16h 57m 1 Seth Chisamore 20/Jul/11 2:06 PM
Closed Closed Reopened Reopened
267d 4h 33m 1 Sean Escriva 12/Apr/12 6:39 PM
Reopened Reopened Resolved Resolved
208d 7h 32m 1 Mike Fiedler 07/Nov/12 2:11 AM
Resolved Resolved Fix Provided Fix Provided
1d 16h 40m 1 jtimberman 08/Nov/12 6:52 PM
Fix Provided Fix Provided Fix Reviewed Fix Reviewed
6m 4s 1 jtimberman 08/Nov/12 6:58 PM
Fix Reviewed Fix Reviewed Fix Committed Fix Committed
1m 54s 1 jtimberman 08/Nov/12 7:00 PM
Fix Committed Fix Committed Closed Closed
11d 4h 20m 1 jtimberman 19/Nov/12 11:20 PM

People

  • Assignee:
    Mike Fiedler
    Reporter:
    Charles Johnson
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: