Refactor aws cookbook to use fog instead of right_aws

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Won't Fix
  • Component/s: aws
  • Labels:
    None

Description

We use the fog gem for all other AWS library usage (knife plugins etc), and the aws cookbook should use it as well for consistency, and to allow additional features to be developed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
jtimberman added a comment -

Newly added to the cookbook via COOK-627 is ELB support. In fog:

https://github.com/fog/fog/blob/master/lib/fog/aws/models/elb/load_balancer.rb

Show
jtimberman added a comment - Newly added to the cookbook via COOK-627 is ELB support. In fog: https://github.com/fog/fog/blob/master/lib/fog/aws/models/elb/load_balancer.rb
Hide
Permalink
Mike Fiedler added a comment -

Is this still a thing? I mean, is it a significant enough different to need a change? The right_aws gem is relatively small, and depends on one other gem - right_http_connection.
fog, on the other hand, pulls in:

builder
excon
fog
formatador
mime-types
multi_json
net-scp
net-ssh
nokogiri
ruby-hmac

That's some 10 vs 2. Do most servers need to have fog on them to execute remote tasks, or is a lightweight library the right choice?

Show
Mike Fiedler added a comment - Is this still a thing? I mean, is it a significant enough different to need a change? The right_aws gem is relatively small, and depends on one other gem - right_http_connection. fog, on the other hand, pulls in: builder excon fog formatador mime-types multi_json net-scp net-ssh nokogiri ruby-hmac That's some 10 vs 2. Do most servers need to have fog on them to execute remote tasks, or is a lightweight library the right choice?
Hide
Permalink
jtimberman added a comment -

Originally when I opened the ticket, fog didn't have nearly as many dependencies.

The number of dependencies isn't really an issue in my opinion, if the net gain is beneficial. The original purpose to use fog was to easily leverage it for other parts of the LWRPs in the cookbook. I don't think this is really necessary now - there is much richer tooling in the AWS ecosystem, some with fine integration with Chef (like Cloud Formation), and I don't know that node convergence is necessarily the place to support that anyway.

Also, the nokogiri gem does have native C extensions, which requires build tools. While I'm not opposed to build tools installed on production servers, some folks are.

That said, I agree, let's close this ticket.

Show
jtimberman added a comment - Originally when I opened the ticket, fog didn't have nearly as many dependencies. The number of dependencies isn't really an issue in my opinion, if the net gain is beneficial. The original purpose to use fog was to easily leverage it for other parts of the LWRPs in the cookbook. I don't think this is really necessary now - there is much richer tooling in the AWS ecosystem, some with fine integration with Chef (like Cloud Formation), and I don't know that node convergence is necessarily the place to support that anyway. Also, the nokogiri gem does have native C extensions, which requires build tools. While I'm not opposed to build tools installed on production servers, some folks are. That said, I agree, let's close this ticket.
Hide
Permalink
Chris Griego added a comment -

This might be needed for COOK-1595

Show
Chris Griego added a comment - This might be needed for COOK-1595

People

  • Assignee:
    Unassigned
    Reporter:
    jtimberman
Vote (2)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: