mercurial lwrp for scm repo management

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Component/s: mercurial
  • Labels:
    None

Issue Links

relates to

New Feature - A new feature of the product, which has yet to be developed. COOK-1179 Add LWRP to mercurial

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
ZombieDev added a comment -

May have fixed this in the COOK-879 branch of this clone:
https://github.com/zombiedev/cookbooks/tree/COOK-879

I haven't tested this yet as I'm on Windows machine right now and I don't think the SCM resources and providers will work well with chef-solo on windows. Will try post a chef-client run showing this works sometime in the next few days.

Show
ZombieDev added a comment - May have fixed this in the COOK-879 branch of this clone: https://github.com/zombiedev/cookbooks/tree/COOK-879 I haven't tested this yet as I'm on Windows machine right now and I don't think the SCM resources and providers will work well with chef-solo on windows. Will try post a chef-client run showing this works sometime in the next few days.
Hide
Permalink
ZombieDev added a comment -

I just realized this isn't a LWRP but rather subclasses of Chef::Resource and Chef::Provider. Maybe this doesn't belong on this bug. I coded it this way because that's how the Git and Subversion SCM resources / providers work.

Show
ZombieDev added a comment - I just realized this isn't a LWRP but rather subclasses of Chef::Resource and Chef::Provider. Maybe this doesn't belong on this bug. I coded it this way because that's how the Git and Subversion SCM resources / providers work.
Hide
Permalink
jtimberman added a comment -

Because this ticket was not in "resolved" status, it was not noticed when we did code review for the COOK project, but COOK-1179 was, and I merged that. Sorry I missed this!

Having a mercurial SCM provider is good, any way you slice it. Ideally, such a provider would subclass Chef's built in SCM resource so it can be used similar to the subversion and git resources (as well as in other places like the deploy resource).

Thoughts on improving this library to do that? Noah Kantrowitz also did done some work on this kind of provider.

Show
jtimberman added a comment - Because this ticket was not in "resolved" status, it was not noticed when we did code review for the COOK project, but COOK-1179 was, and I merged that. Sorry I missed this! Having a mercurial SCM provider is good, any way you slice it. Ideally, such a provider would subclass Chef's built in SCM resource so it can be used similar to the subversion and git resources (as well as in other places like the deploy resource). Thoughts on improving this library to do that? Noah Kantrowitz also did done some work on this kind of provider.
Hide
Permalink
Guilhem Lettron added a comment -

this commit add the feature c63e55f579b8ff47354f75917eaa9d6023dc831c
https://github.com/opscode-cookbooks/mercurial/commit/c63e55f579b8ff47354f75917eaa9d6023dc831c

I think we can close this issue

Show
Guilhem Lettron added a comment - this commit add the feature c63e55f579b8ff47354f75917eaa9d6023dc831c https://github.com/opscode-cookbooks/mercurial/commit/c63e55f579b8ff47354f75917eaa9d6023dc831c I think we can close this issue
Hide
Permalink
Guilhem Lettron added a comment -

duplicate of COOK-1179

Show
Guilhem Lettron added a comment - duplicate of COOK-1179

People

  • Assignee:
    Guilhem Lettron
    Reporter:
    jtimberman
Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: