Teach ec2_create_server the --ssh-port option

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: ec2-0.5.12
  • Component/s: knife-ec2
  • Labels:

Description

We should be able to ssh into the newly created instance on a non-standard port.
I opened a pull request https://github.com/opscode/knife-ec2/pull/28

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Max Rabin added a comment -

Pull request at https://github.com/opscode/knife-ec2/pull/28 for commit located at https://github.com/maxrabin/knife-ec2/commit/38efc404693d4bebe401078b79ed516d206c3880

Show
Max Rabin added a comment - Pull request at https://github.com/opscode/knife-ec2/pull/28 for commit located at https://github.com/maxrabin/knife-ec2/commit/38efc404693d4bebe401078b79ed516d206c3880
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Max,

This looks good but could you add a little test to go along with those for the others options? The framework that we have set up for these options wasn't great, and we need to refactor it in the future. A test will help ensure we don't break this feature when we do.

Show
Bryan McLellan [Opscode] added a comment - Max, This looks good but could you add a little test to go along with those for the others options? The framework that we have set up for these options wasn't great, and we need to refactor it in the future. A test will help ensure we don't break this feature when we do.
Hide
Permalink
Max Rabin added a comment -

OK I updated the pull request.

Show
Max Rabin added a comment - OK I updated the pull request.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Awesome! Thanks. Marked to be merged.

Show
Bryan McLellan [Opscode] added a comment - Awesome! Thanks. Marked to be merged.
Hide
Permalink
Steven Danna added a comment -

Thanks! Merged: https://github.com/opscode/knife-ec2/commit/76cc836a2f81955ef8c29c189cf4e7a1e61fc609

Show
Steven Danna added a comment - Thanks! Merged: https://github.com/opscode/knife-ec2/commit/76cc836a2f81955ef8c29c189cf4e7a1e61fc609

People

  • Assignee:
    Max Rabin
    Reporter:
    Max Rabin
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: