I would like to get this feature into the next release. However, after looking at both available pull requests, I think we might still need to do some work:
1) https://github.com/opscode/knife-ec2/pull/24/files fails with the following error:
$ knife ec2 server create -I ami-3962a950 -S steve -i ~/certificates/steve.pem -x ubuntu --tags Wombat,sauce -VV
DEBUG: Using configuration from /Users/sdanna/src/oc/steve-ocs/.chef/knife.rb
/Users/sdanna/.rvm/gems/ruby-1.9.2-p290@global/gems/knife-ec2-0.5.11/lib/chef/knife/ec2_server_create.rb:199:in `run': undefined local variable or method `tags' for #<Chef::Knife::Ec2ServerCreate:0x007fd95d1e6430> (NameError)
from /Users/sdanna/.rvm/gems/ruby-1.9.2-p290@global/gems/chef-0.10.8/lib/chef/knife.rb:391:in `run_with_pretty_exceptions'
from /Users/sdanna/.rvm/gems/ruby-1.9.2-p290@global/gems/chef-0.10.8/lib/chef/knife.rb:166:in `run'
from /Users/sdanna/.rvm/gems/ruby-1.9.2-p290@global/gems/chef-0.10.8/lib/chef/application/knife.rb:128:in `run'
from /Users/sdanna/.rvm/gems/ruby-1.9.2-p290@global/gems/chef-0.10.8/bin/knife:25:in `<top (required)>'
from /Users/sdanna/.rvm/gems/ruby-1.9.2-p290@global/bin/knife:19:in `load'
from /Users/sdanna/.rvm/gems/ruby-1.9.2-p290@global/bin/knife:19:in `<main>'
2) Both patches only try to set the Name attribute in the case where other tags have been set. This seems a bit counter intuitive to me when testing it. For instance calling:
knife ec2 server create -I some_AMI -S some_key -N MYCOOLNODENAME
does not set the Name tag. However,
knife ec2 server create -I some_AMI -S some_key -N MYCOOLNODENAME --tags completely=unrelated
I believe there is some value in having the syntax be similar to the ec2 command line tools.
Marx: Can you fix up your branch related to point (2) above?