Failing specs

Fixed at https://github.com/greenalto/knife-ec2/tree/KNIFE_EC2-39

Hi! Thanks for this! We love tests!

There appears to be additional cruft in the branch, in addition to what this ticket aims to fix. We try to keep tickets, and the branches that go with them, topical. This way other developers in the community can use the tickets to understand what the problem or feature was that the branch or commit is solving or adding.

For instance, I see multiple references to the travis-ci [1] project. I'm not familiar with it, so I don't know if we would want to build in support into the project or not, but we should do so in another ticket at least.

You also bump the dependency for fog. We're really cautious about this sort of thing. First, we want to be sure that we're tested on those releases and we don't see any comments here about the possible repercussions of that move. That should also be another ticket. Sometimes requiring one gem of a newer version can pull in a number of dependencies. We also build our software out in other packaging systems, so we like to have it documented why we increased the dependency. Was there a feature or a fix that was needed?

If you could split unrelated commits into other tickets, we could review the spec tests more thoroughly and provide better advice to you.

Once again, thanks for contributing!
[1] http://about.travis-ci.org/

I'm going to delete the extra staff from this branch. The fog version bump was a mistake, I'll fix this as well.

I'll let you guys know when I'm done!

I've fixed the currently failing spec (diff is here: https://github.com/greenalto/knife-ec2/commit/d4aeca1bbffdd341086e4064bd484be6485fae21) and changed just enough to make them pass (dependencies missing on chef, added rspec to the Gemfile). I've also added Gemfile.lock to the repo (it's recommended by the Bundler authors).

I couldn't find out which chef version is supported by the current version knife-ec2 so I've used '~> 0.10', I can change this if you know the answer.

Here is the branch: https://github.com/greenalto/knife-ec2/tree/KNIFE_EC2-39

There's been some commits recently so I'll have to work some more on specs for the other classes later. I'm also interested in improving the current one, but right now I need some sleep! I think adding your projects to Travis CI will benefit you, it's a community-backed Continuous Integration server with support for multiple Ruby versions.

Let me know when you guys have reviewed it, this has been tested on both Ruby 1.9.3-p0 and 1.8.7-p352.

-------------
By the way I've also found out there's a mixup in the gemspec (Rackspace instead of Amazon EC2). Should I create a ticket for this or will someone from Opscode change it ?
See https://rubygems.org/gems/knife-ec2 ("Rackspace Support for Chef's Knife Command")
https://github.com/greenalto/knife-ec2/commit/2854228947c2f59c287bc6ce161f34649cced355

Thanks. Marked to be merged.

We had a memory of a problem with depending on Chef in the gemspec, but we can't remember what it was. We thought it might have been that gem would pull in the latest version of dependencies, but we couldn't produce that. So that's okay unless we can figure out why.

We'll grab that rackspace text issue, thanks for catching that.

Merged! Thanks again! (https://github.com/opscode/knife-ec2/commit/6bce5d546dde37f9338a66876eb707bf6c71473c)