Added ability to pass in user_data_file

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: openstack-0.5.4
  • Fix Version/s: None
  • Component/s: knife-openstack
  • Labels:
    None
  • Environment:

    chef ~> 0.10.0

Description

Added the ability to pass user_data when starting an instance.
Useful for those that may want to execute something before chef kicks in.

I do realize this is somewhat subverting chef to a certain extent, but for those that use it properly I think it's a nice-to-have.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
John Dewey added a comment -

I should probably supply the pull request link

https://github.com/opscode/knife-openstack/pull/8

Show
John Dewey added a comment - I should probably supply the pull request link https://github.com/opscode/knife-openstack/pull/8
Hide
Permalink
John Dewey added a comment -

Sorry guys. I had knife checked out a while back and had a bad merge.
Here is the proper pull req:

https://github.com/opscode/knife-openstack/pull/9

Apologies for the spam

Show
John Dewey added a comment - Sorry guys. I had knife checked out a while back and had a bad merge. Here is the proper pull req: https://github.com/opscode/knife-openstack/pull/9 Apologies for the spam
Hide
Permalink
John Dewey added a comment -

I realized the user_data patch was pointless. One could follow the convention knife has by using -d.
My apologies. I do however have a couple of pulls still, if you dont mind getting to those.

Show
John Dewey added a comment - I realized the user_data patch was pointless. One could follow the convention knife has by using -d. My apologies. I do however have a couple of pulls still, if you dont mind getting to those.
Hide
Permalink
John Dewey added a comment -

Curious if these fixes in my fork were useful. If not i'll just request this ticket be closed.

Show
John Dewey added a comment - Curious if these fixes in my fork were useful. If not i'll just request this ticket be closed.
Hide
Permalink
John Dewey added a comment -

Closed per reporter (me).

Show
John Dewey added a comment - Closed per reporter (me).
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

We usually ask that separate patches be on separate tickets so they can be evaluated separately. In the future, we only regularly review contributions on tickets that are marked 'resolved/fixed' by the contributor. Please remember to resolve tickets that have a patch you would like us to take a look at.

P.S. I know Matt Ray has been doing some work on improving knife-openstack recently.

Show
Bryan McLellan [Opscode] added a comment - We usually ask that separate patches be on separate tickets so they can be evaluated separately. In the future, we only regularly review contributions on tickets that are marked 'resolved/fixed' by the contributor. Please remember to resolve tickets that have a patch you would like us to take a look at. P.S. I know Matt Ray has been doing some work on improving knife-openstack recently.

People

  • Assignee:
    John Dewey
    Reporter:
    John Dewey
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: