Refactor node data structure for bb's sanity

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.1.2
  • Component/s: Plugin DSL
  • Labels:
    None
  • Environment:

    All environments

Description

Refactor node data structure for my sanity. Top level entities should be truly global; canonical versions where appropriate should be derived and put in top level (e.g., canonical fqdn, canonical ip address). System information that does not require canonicalization should be be put appropriate sub-structures (e.g., memory information, language versions) instead of in the top level.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Adam Jacob added a comment -

This is done - see https://github.com/hjkp/ohai/commit/39bfe95

Show
Adam Jacob added a comment - This is done - see https://github.com/hjkp/ohai/commit/39bfe95
Hide
Permalink
Adam Jacob added a comment -

Re-opening to hand off to Ben for sanity check.

Show
Adam Jacob added a comment - Re-opening to hand off to Ben for sanity check.
Hide
Permalink
Adam Jacob added a comment -

Attached is the new Ohai.json under linux.

BB, proposed changes?

Show
Adam Jacob added a comment - Attached is the new Ohai.json under linux. BB, proposed changes?
Hide
Permalink
Adam Jacob added a comment -

I believe this is fixed - please review and update as needed.

Show
Adam Jacob added a comment - I believe this is fixed - please review and update as needed.
Hide
Permalink
Benjamin Black added a comment -

i suggest these changes:

["swap"] -> ["memory"]["swap"] , and should include pageins/pageouts
["ssh"] -> ["keys"]["ssh"] , because there will be other keys/certs we want to track
["ruby"] -> ["languages"]["ruby"] , because there will be other languages of interest

i will open another ticket for the network interface refactor.

Show
Benjamin Black added a comment - i suggest these changes: ["swap"] -> ["memory"] ["swap"] , and should include pageins/pageouts ["ssh"] -> ["keys"] ["ssh"] , because there will be other keys/certs we want to track ["ruby"] -> ["languages"] ["ruby"] , because there will be other languages of interest i will open another ticket for the network interface refactor.
Hide
Permalink
Adam Jacob added a comment -

This is fixed

Show
Adam Jacob added a comment - This is fixed

People

  • Assignee:
    Adam Jacob
    Reporter:
    Benjamin Black
Vote (0)
Watch (0)

Dates

  • Due:
    Created:
    Updated:
    Resolved: