ohai -d option parsing bug?

Details

  • Type: Bug Bug
  • Status: Fix Provided Fix Provided
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 6.16.0
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Environment:

    RHEL5, ruby 1.8.5 (2006-08-25) [x86_64-linux], Ohai, version 0.3.2

Description

Running ohai from the command line with the -d option does not include plugins found in the directory if the dir argument ends with a slash, i.e.

$ ohai -d /etc/ohai/plugins/

does not load the plugins in /etc/ohai/plugins directory while

$ ohai -d /etc/ohai/plugins

loads them succesfully

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. OHAI-231 ohai -d /some/directory/ with trailing slash does not work

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eugene Wood added a comment -

I've provided a fix for this here :

https://github.com/opscode/ohai/pull/117

Feel free to test and merge if you like it.

Show
Eugene Wood added a comment - I've provided a fix for this here : https://github.com/opscode/ohai/pull/117 Feel free to test and merge if you like it.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

This works too, might be a bit more resilient

file_regex = Regexp.new("#{File.expand_path(path)}#{File::SEPARATOR}(.+).rb$")

Also should add a regression test.

Show
Bryan McLellan [Opscode] added a comment - This works too, might be a bit more resilient file_regex = Regexp. new ( "#{File.expand_path(path)}#{File::SEPARATOR}(.+).rb$" ) Also should add a regression test.

People

  • Assignee:
    Unassigned
    Reporter:
    Sergio Rubio
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: