Detect raid hardware.

Details

  • Type: New Feature New Feature
  • Status: Open Open
  • Priority: Unknown Unknown
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Detect raid hardware installed on the platform. One method used by https://github.com/rottenbytes/chef/tree/master/ohai/files/default/plugins

makes use of lsipci

I integrated it here
https://github.com/ChrisLundquist/ohai
and verified it worked on a few raid card models. (ran on Centos)

I haven't packed gems before so I might have broken the Rakefile. It was complaining about undefined variables on my platform.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mike Fiedler added a comment -

https://github.com/opscode/ohai/pull/37

Show
Mike Fiedler added a comment - https://github.com/opscode/ohai/pull/37
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Please use run_command or mixlib-shellout instead of backticks for running commands. We've worked around a lot of common issues in these libraries.

The pull request also includes a darwin cpu plugin, which looks fine, but should be a separate ticket.

The raid plugin headers attribute the code to 'Nicolas Szalay' but you are not him and I do not see his name on the approved contributor list. Where did this code come from?

Show
Bryan McLellan [Opscode] added a comment - Please use run_command or mixlib-shellout instead of backticks for running commands. We've worked around a lot of common issues in these libraries. The pull request also includes a darwin cpu plugin, which looks fine, but should be a separate ticket. The raid plugin headers attribute the code to 'Nicolas Szalay' but you are not him and I do not see his name on the approved contributor list. Where did this code come from?
Hide
Permalink
Chris Lundquist added a comment -

It was based of off
https://github.com/rottenbytes/chef/commit/91c829fc6172d1b00f937fe9766ef9ffa3ecf7bf

under the WTFPL license
https://github.com/rottenbytes/chef/blob/master/README.md

I emailed him formally asking for consent and it was granted. I do not have the email as it was from about 2 years ago.

Show
Chris Lundquist added a comment - It was based of off https://github.com/rottenbytes/chef/commit/91c829fc6172d1b00f937fe9766ef9ffa3ecf7bf under the WTFPL license https://github.com/rottenbytes/chef/blob/master/README.md I emailed him formally asking for consent and it was granted. I do not have the email as it was from about 2 years ago.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Thanks, that should be okay to be submitted for a third party under section 8 of the CLA.

Could you make the improvement to use shellout?

Show
Bryan McLellan [Opscode] added a comment - Thanks, that should be okay to be submitted for a third party under section 8 of the CLA. Could you make the improvement to use shellout?
Hide
Permalink
Nicolas Szalay added a comment -

As the author I do confirm I'm OK with that

Show
Nicolas Szalay added a comment - As the author I do confirm I'm OK with that

People

  • Assignee:
    Unassigned
    Reporter:
    Chris Lundquist
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: