platform_version not returned when running under Windows Ruby 1.9.x

Details

Type: Bug
Status: Open
Priority: Blocker
Resolution: Unresolved
Affects Version/s: 0.6.8, 0.6.10, 6.14.0, 6.16.0
Fix Version/s: None
Component/s: Kernel, Platform
Labels:
- windows
- windows-support-blockers
Environment:

Windows Server 2008 R2 or Windows 7 or Windows XP Pro 2002 SP3
Ruby 1.9.2 or 1.9.3 (RubyInstaller + DevKit)

Description

Ohai does not return a platform_version when running under Windows Ruby 1.9. The short story is the latest version (2.4.0) of 'systemu' is broken on Windows Ruby 1.9:

C:\Ruby192\bin>irb
irb(main):001:0> require 'systemu'
=> true
irb(main):002:0> systemu('ruby --version')
RuntimeError: wtf?
o:↕ArgumentError:       mesg"∟dump format error(0x67):bt[I"rC:/Users/ADMINI~1/Ap
pData/Local/Temp/2/systemu_ip-0ADC899B_2824_1916_0.8916156963740122_1/program:3:
in `load'♠:
encoding"♂IBM437I"tC:/Users/ADMINI~1/AppData/Local/Temp/2/systemu_ip-0ADC899B_28
24_1916_0.8916156963740122_1/program:3:in `<main>'♠@

        from C:/Ruby192/lib/ruby/gems/1.9.1/gems/systemu-2.4.0/lib/systemu.rb:88
:in `rescue in block (3 levels) in systemu'
        from C:/Ruby192/lib/ruby/gems/1.9.1/gems/systemu-2.4.0/lib/systemu.rb:81
:in `block (3 levels) in systemu'
        from C:/Ruby192/lib/ruby/gems/1.9.1/gems/systemu-2.4.0/lib/systemu.rb:75
:in `popen'
        from C:/Ruby192/lib/ruby/gems/1.9.1/gems/systemu-2.4.0/lib/systemu.rb:75
:in `block (2 levels) in systemu'
        from C:/Ruby192/lib/ruby/gems/1.9.1/gems/systemu-2.4.0/lib/systemu.rb:16
7:in `quietly'
        from C:/Ruby192/lib/ruby/gems/1.9.1/gems/systemu-2.4.0/lib/systemu.rb:74
:in `block in systemu'
        from C:/Ruby192/lib/ruby/gems/1.9.1/gems/systemu-2.4.0/lib/systemu.rb:23
3:in `call'
        from C:/Ruby192/lib/ruby/gems/1.9.1/gems/systemu-2.4.0/lib/systemu.rb:23
3:in `block in tmpdir'
        from C:/Ruby192/lib/ruby/gems/1.9.1/gems/systemu-2.4.0/lib/systemu.rb:21
8:in `loop'
        from C:/Ruby192/lib/ruby/gems/1.9.1/gems/systemu-2.4.0/lib/systemu.rb:21
8:in `tmpdir'
        from C:/Ruby192/lib/ruby/gems/1.9.1/gems/systemu-2.4.0/lib/systemu.rb:67
:in `systemu'
        from C:/Ruby192/lib/ruby/gems/1.9.1/gems/systemu-2.4.0/lib/systemu.rb:9:
in `systemu'
        from (irb):2
        from C:/Ruby192/bin/irb:12:in `<main>'

This causes any Ohai plugin that 'shell outs' to fail. The worst of these failures stops the windows::kernel plugin from loading and many required attributes (namely kernel[:release]) are not set.

The short-term fix is to downgrade (and peg) the last known working version of systemu (2.2.0) required by Ohai.

Issue Links

is depended on by

CHEF-2366 chef-solo fails on windows

is duplicated by

OHAI-373 systemu 2.5.0 causing exceptions

relates to

OHAI-271 ohai gemspec should include dependent windows platform gems

OHAI-447 Refactor ruby-wmi usage

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Seth Chisamore added a comment - 21/Oct/11 4:21 AM

Fix can be pulled from:
https://github.com/schisamo/ohai/tree/OHAI-306

Show

Seth Chisamore added a comment - 21/Oct/11 4:21 AM Fix can be pulled from: https://github.com/schisamo/ohai/tree/OHAI-306

Hide

Permalink

Bryan McLellan [Opscode] added a comment - 21/Oct/11 1:58 PM

What a tangled web you weave, Rubygems.

The pessimistic version constraint on 2.2.0 may not be needed since they've already jumped from 2.2.0 to 2.4.0. There's no need for pessimism when you've already lost.

Show

Bryan McLellan [Opscode] added a comment - 21/Oct/11 1:58 PM What a tangled web you weave, Rubygems. The pessimistic version constraint on 2.2.0 may not be needed since they've already jumped from 2.2.0 to 2.4.0. There's no need for pessimism when you've already lost.

Hide

Permalink

Bryan McLellan [Opscode] added a comment - 21/Oct/11 2:49 PM

Merged

Show

Bryan McLellan [Opscode] added a comment - 21/Oct/11 2:49 PM Merged

Hide

Permalink

Jim Meyer added a comment - 29/Feb/12 7:07 PM

Reported to the systemu project as it seemed no one had: https://github.com/ahoward/systemu/issues/14

Show

Jim Meyer added a comment - 29/Feb/12 7:07 PM Reported to the systemu project as it seemed no one had: https://github.com/ahoward/systemu/issues/14

Hide

Permalink

Jim Meyer added a comment - 02/Mar/12 3:22 PM

Got a reply from the Github ticket mentioned above (https://github.com/ahoward/systemu/issues/14#issuecomment-4272319):

This is an issue with the use of YAML (before the syck fix) and Marshal on Windows. Using inspect works. I made a patch that adds a parameter that allows you to chose a serialization strategy, see https://github.com/ahoward/systemu/pull/8

I'm stepping out of this as I have no access to a Windows box. If there's someone more invested, please pick up the thread and see if there's action needed on our side.

Show

Jim Meyer added a comment - 02/Mar/12 3:22 PM Got a reply from the Github ticket mentioned above ( https://github.com/ahoward/systemu/issues/14#issuecomment-4272319): This is an issue with the use of YAML (before the syck fix) and Marshal on Windows. Using inspect works. I made a patch that adds a parameter that allows you to chose a serialization strategy, see https://github.com/ahoward/systemu/pull/8 I'm stepping out of this as I have no access to a Windows box. If there's someone more invested, please pick up the thread and see if there's action needed on our side.

Hide

Permalink

Bryan McLellan [Opscode] added a comment - 15/May/12 7:40 PM

The gem requirements created when the gem is created, not when it is installed, so this solution doesn't really work. See OHAI-271 where this will likely be fixed.

Show

Bryan McLellan [Opscode] added a comment - 15/May/12 7:40 PM The gem requirements created when the gem is created, not when it is installed, so this solution doesn't really work. See OHAI-271 where this will likely be fixed.

Hide

Permalink

Bryan McLellan [Opscode] added a comment - 15/May/12 10:00 PM

https://s3.amazonaws.com/opscode-full-stack/windows/chef-client-0.10.10-3.msi

This MSI has Ohai 0.6.10 (~~OHAI-351~~) and systemu 2.2.0 built into it.

The later will remain hardcoded in our build system until we come up with a better solution.

Show

Bryan McLellan [Opscode] added a comment - 15/May/12 10:00 PM https://s3.amazonaws.com/opscode-full-stack/windows/chef-client-0.10.10-3.msi This MSI has Ohai 0.6.10 ( OHAI-351 ) and systemu 2.2.0 built into it. The later will remain hardcoded in our build system until we come up with a better solution.

Hide

Permalink

Bryan McLellan [Opscode] added a comment - 10/Dec/12 6:56 PM - edited

I merged systemu PR #8 into master today and tried it on Windows 7 Professional with Chef 10.16.2 and it still fails because of encoding problems.

[2012-12-10T13:41:48-05:00] INFO: *** Chef 10.16.2 ***
[2012-12-10T13:41:57-05:00] FATAL: Stacktrace dumped to C:/chef/cache/chef-stacktrace.out
[2012-12-10T13:41:57-05:00] FATAL: NoMethodError: undefined method `run_list' for nil:NilClass

Show

Bryan McLellan [Opscode] added a comment - 10/Dec/12 6:56 PM - edited I merged systemu PR #8 into master today and tried it on Windows 7 Professional with Chef 10.16.2 and it still fails because of encoding problems. [2012-12-10T13:41:48-05:00] INFO: *** Chef 10.16.2 *** [2012-12-10T13:41:57-05:00] FATAL: Stacktrace dumped to C:/chef/cache/chef-stacktrace.out [2012-12-10T13:41:57-05:00] FATAL: NoMethodError: undefined method `run_list' for nil:NilClass

Hide

Permalink

Larry Gilbert added a comment - 03/Jan/13 5:27 PM

FWIW... I am having a like problem on this setup:

Windows 7 Enterprise SP 1
Ruby 1.9.2p290 [i386-mingw32]
chef 10.16.4
ohai 6.14.0
systemu 2.2.0

Running chef-solo gives me this output:

[2013-01-03T09:21:31-08:00] INFO: *** Chef 10.16.4 ***
[2013-01-03T09:22:16-08:00] FATAL: Stacktrace dumped to C:/chef/chef-stacktrace.out
[2013-01-03T09:22:16-08:00] FATAL: ArgumentError: Cannot find a version for node[XXXXXXXXXXXX.XXXXXXX.XXXX]

...and this stack trace:

Generated at 2013-01-03 09:22:16 -0800
ArgumentError: Cannot find a version for node[XXXXXXXXXXXX.XXXXXXX.XXXX]
C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/platform.rb:367:in `find_platform_and_version'
C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/node.rb:384:in `consume_external_attrs'
C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/client.rb:252:in `build_node'
C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/client.rb:412:in `do_run'
C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/client.rb:176:in `run'
C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/application.rb:140:in `run_chef_client'
C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/application/solo.rb:224:in `block in run_application'
C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/application/solo.rb:216:in `loop'
C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/application/solo.rb:216:in `run_application'
C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/application.rb:72:in `run'
C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/bin/chef-solo:25:in `<top (required)>'
C:/Ruby192/bin/chef-solo:23:in `load'
C:/Ruby192/bin/chef-solo:23:in `<main>'

But I am using systemu 2.2.0, so I'm wondering whether systemu is the only culprit.

Show

Larry Gilbert added a comment - 03/Jan/13 5:27 PM FWIW... I am having a like problem on this setup: Windows 7 Enterprise SP 1 Ruby 1.9.2p290 [i386-mingw32] chef 10.16.4 ohai 6.14.0 systemu 2.2.0 Running chef-solo gives me this output: [2013-01-03T09:21:31-08:00] INFO: *** Chef 10.16.4 *** [2013-01-03T09:22:16-08:00] FATAL: Stacktrace dumped to C:/chef/chef-stacktrace.out [2013-01-03T09:22:16-08:00] FATAL: ArgumentError: Cannot find a version for node[XXXXXXXXXXXX.XXXXXXX.XXXX] ...and this stack trace: Generated at 2013-01-03 09:22:16 -0800 ArgumentError: Cannot find a version for node[XXXXXXXXXXXX.XXXXXXX.XXXX] C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/platform.rb:367:in `find_platform_and_version' C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/node.rb:384:in `consume_external_attrs' C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/client.rb:252:in `build_node' C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/client.rb:412:in `do_run' C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/client.rb:176:in `run' C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/application.rb:140:in `run_chef_client' C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/application/solo.rb:224:in `block in run_application' C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/application/solo.rb:216:in `loop' C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/application/solo.rb:216:in `run_application' C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib/chef/application.rb:72:in `run' C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/bin/chef-solo:25:in `<top (required)>' C:/Ruby192/bin/chef-solo:23:in `load' C:/Ruby192/bin/chef-solo:23:in `<main>' But I am using systemu 2.2.0, so I'm wondering whether systemu is the only culprit.

Hide

Permalink

Larry Gilbert added a comment - 03/Jan/13 5:34 PM - edited

This might be of more interest--some direct output from Ohai:

{
  "languages": {
    "ruby": {
      "platform": "i386-mingw32",
      "version": "1.9.2",
      "release_date": "2011-07-09",
      "target": "i386-pc-mingw32",
      "target_cpu": "i386",
      "target_vendor": "pc",
      "target_os": "mingw32",
      "host": "i686-pc-mingw32",
      "host_cpu": "i686",
      "host_os": "mingw32",
      "host_vendor": "pc",
      "bin_dir": "C:/Ruby192/bin",
      "ruby_bin": "C:/Ruby192/bin/ruby",
      "gems_dir": "C:/Ruby192/lib/ruby/gems/1.9.1",
      "gem_bin": "C:/Ruby192/bin/gem"
    },
    "java": {
      "version": "1.6.0_35",
      "runtime": {
        "name": "Java(TM) SE Runtime Environment",
        "build": "1.6.0_35-b10"
      },
      "hotspot": {
        "name": "Java HotSpot(TM) Client VM",
        "build": "20.10-b01, mixed mode, sharing"
      }
    },
    "perl": {
      "version": "5.8.8",
      "archname": "MSWin32-x86-multi-thread"
    }
  },
  "kernel": {
    "os_info": {
      "boot_device": "\\Device\\HarddiskVolume1",
      "build_number": "7601",
      "build_type": "Multiprocessor Free",
      "caption": "Microsoft Windows 7 Enterprise ",
      "code_set": "1252",
      "country_code": "1",
      "creation_class_name": "Win32_OperatingSystem",
      "cs_creation_class_name": "Win32_ComputerSystem",
      "csd_version": "Service Pack 1",
      "cs_name": "XXXXXXXXXXXX",
      "current_time_zone": -480
    }
  },
  "os": "windows",
  "os_version": null,
  "chef_packages": {
    "chef": {
      "version": "10.16.4",
      "chef_root": "C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib"
    },
    "ohai": {
      "version": "6.14.0",
      "ohai_root": "C:/Ruby192/lib/ruby/gems/1.9.1/gems/ohai-6.14.0/lib/ohai"
    }
  },

Show

Larry Gilbert added a comment - 03/Jan/13 5:34 PM - edited This might be of more interest--some direct output from Ohai: { "languages": { "ruby": { "platform": "i386-mingw32", "version": "1.9.2", "release_date": "2011-07-09", "target": "i386-pc-mingw32", "target_cpu": "i386", "target_vendor": "pc", "target_os": "mingw32", "host": "i686-pc-mingw32", "host_cpu": "i686", "host_os": "mingw32", "host_vendor": "pc", "bin_dir": "C:/Ruby192/bin", "ruby_bin": "C:/Ruby192/bin/ruby", "gems_dir": "C:/Ruby192/lib/ruby/gems/1.9.1", "gem_bin": "C:/Ruby192/bin/gem" }, "java": { "version": "1.6.0_35", "runtime": { "name": "Java(TM) SE Runtime Environment", "build": "1.6.0_35-b10" }, "hotspot": { "name": "Java HotSpot(TM) Client VM", "build": "20.10-b01, mixed mode, sharing" } }, "perl": { "version": "5.8.8", "archname": "MSWin32-x86-multi-thread" } }, "kernel": { "os_info": { "boot_device": "\\Device\\HarddiskVolume1", "build_number": "7601", "build_type": "Multiprocessor Free", "caption": "Microsoft Windows 7 Enterprise ", "code_set": "1252", "country_code": "1", "creation_class_name": "Win32_OperatingSystem", "cs_creation_class_name": "Win32_ComputerSystem", "csd_version": "Service Pack 1", "cs_name": "XXXXXXXXXXXX", "current_time_zone": -480 } }, "os": "windows", "os_version": null , "chef_packages": { "chef": { "version": "10.16.4", "chef_root": "C:/Ruby192/lib/ruby/gems/1.9.1/gems/chef-10.16.4/lib" }, "ohai": { "version": "6.14.0", "ohai_root": "C:/Ruby192/lib/ruby/gems/1.9.1/gems/ohai-6.14.0/lib/ohai" } },

Hide

Permalink

Larry Gilbert added a comment - 03/Jan/13 8:15 PM

It looks like the method of collecting WMI properties used in lib/ohai/plugins/windows/kernel.rb does not work as intended. Example:

host = WMI::Win32_OperatingSystem.find(:first)
kernel[:os_info] = Mash.new
host.properties_.each do |p|
  kernel[:os_info][p.name.wmi_underscore.to_sym] = host.send(p.name)
end

When I changed the loop to use #attributes instead of #properties_:

host.attributes.each_pair do |key, val|
  kernel[:os_info][key.to_sym] = val
end

all of the WMI data was collected and the version strings came through as expected.

Show

Larry Gilbert added a comment - 03/Jan/13 8:15 PM It looks like the method of collecting WMI properties used in lib/ohai/plugins/windows/kernel.rb does not work as intended. Example: host = WMI::Win32_OperatingSystem.find(:first) kernel[:os_info] = Mash. new host.properties_.each do |p| kernel[:os_info][p.name.wmi_underscore.to_sym] = host.send(p.name) end When I changed the loop to use #attributes instead of #properties_ : host.attributes.each_pair do |key, val| kernel[:os_info][key.to_sym] = val end all of the WMI data was collected and the version strings came through as expected.

Hide

Permalink

Larry Gilbert added a comment - 09/Jan/13 8:08 PM

I've added some new metadata to this ticket for additional places I've seen this bug.

The things they have in common are that they're on various versions of Windows and they're all Ruby 1.9.x. (When I tried it in 1.8.7p352 on Windows XP, platform_version was set correctly.)

Show

Larry Gilbert added a comment - 09/Jan/13 8:08 PM I've added some new metadata to this ticket for additional places I've seen this bug. The things they have in common are that they're on various versions of Windows and they're all Ruby 1.9.x. (When I tried it in 1.8.7p352 on Windows XP, platform_version was set correctly.)

Hide

Permalink

Larry Gilbert added a comment - 09/Jan/13 8:29 PM

I've made a pull request for the change I described above.

https://github.com/opscode/ohai/pull/120

Show

Larry Gilbert added a comment - 09/Jan/13 8:29 PM I've made a pull request for the change I described above. https://github.com/opscode/ohai/pull/120

Hide

Permalink

Larry Gilbert added a comment - 17/Jan/13 7:47 PM

Any chance this can be applied in time for 6.18.0?

Show

Larry Gilbert added a comment - 17/Jan/13 7:47 PM Any chance this can be applied in time for 6.18.0?

Hide

Permalink

Larry Gilbert added a comment - 05/Feb/13 8:14 PM

I found one other edge case.

Even though Ohai's gemspec specifies systemu ~> 2.2.0, this is not enforced in the Ohai code itself. So if a Windows system has systemu 2.2.0 and a newer version installed, Ohai will use the newer version (and thus this will continue to break).

I will make an additional pull request for this, but it boils down to adding the following code to lib/ohai/mixin/command.rb (mirroring the gemspec):

if RUBY_PLATFORM =~ /mswin|mingw32|windows/
  gem 'systemu', '~> 2.2.0'
end

Show

Larry Gilbert added a comment - 05/Feb/13 8:14 PM I found one other edge case. Even though Ohai's gemspec specifies systemu ~> 2.2.0, this is not enforced in the Ohai code itself. So if a Windows system has systemu 2.2.0 and a newer version installed, Ohai will use the newer version (and thus this will continue to break). I will make an additional pull request for this, but it boils down to adding the following code to lib/ohai/mixin/command.rb (mirroring the gemspec): if RUBY_PLATFORM =~ /mswin|mingw32|windows/ gem 'systemu', '~> 2.2.0' end

Hide

Permalink

Larry Gilbert added a comment - 07/Feb/13 7:56 PM

Reopening because I have one more fix to submit.

Show

Larry Gilbert added a comment - 07/Feb/13 7:56 PM Reopening because I have one more fix to submit.

Hide

Permalink

Larry Gilbert added a comment - 11/Feb/13 7:51 PM

If anyone still experiencing this problem could try out the changes I've talked about in OHAI-447 and let me know whether those changes help (or cause new problems), I would welcome some feedback. I have a link there to my GitHub repo with the changes. Thanks!

Show

Larry Gilbert added a comment - 11/Feb/13 7:51 PM If anyone still experiencing this problem could try out the changes I've talked about in OHAI-447 and let me know whether those changes help (or cause new problems), I would welcome some feedback. I have a link there to my GitHub repo with the changes. Thanks!

People

Assignee:

Seth Chisamore

Reporter:

Seth Chisamore

Vote (1)

Watch (3)

Dates

Created:

21/Oct/11 3:51 AM

Updated:

12/Mar/13 12:59 AM