virt and lsb spec's lack use of should/should_not

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.2.0
  • Component/s: None
  • Labels:
    None

Description

some specs are missing should / should_not and always eval true unless something goes wrong in the setup code.

linux/virtualization_spec.rb
linux/lsb_spec.rb

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Thom May added a comment -

http://github.com/thommay/ohai/tree/OHAI-40 is where I am currently; it's ugly but it works.

Show
Thom May added a comment - http://github.com/thommay/ohai/tree/OHAI-40 is where I am currently; it's ugly but it works.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

@ohai is an Ohai::System object, which has require_plugin and calls from_file which it gains as a mixin. from_file uses File.exists? which breaks loading the plugin we are testing if we arbitrarily mock or stub it.

I figured out [1] how to override the from_file method, but holoway [2] came up with a more general solution that only adds one line of code to each spec file. This is better since we'll surely run into this problem again.

[1] http://github.com/btm/ohai/blob/96bfa27cdf49c6d7e1a97fb63a91b10bebd3b19e/spec/ohai/plugins/linux/virtualization_spec.rb#L26
[2] http://gist.github.com/56815

Show
Bryan McLellan [Opscode] added a comment - @ohai is an Ohai::System object, which has require_plugin and calls from_file which it gains as a mixin. from_file uses File.exists? which breaks loading the plugin we are testing if we arbitrarily mock or stub it. I figured out [1] how to override the from_file method, but holoway [2] came up with a more general solution that only adds one line of code to each spec file. This is better since we'll surely run into this problem again. [1] http://github.com/btm/ohai/blob/96bfa27cdf49c6d7e1a97fb63a91b10bebd3b19e/spec/ohai/plugins/linux/virtualization_spec.rb#L26 [2] http://gist.github.com/56815
Hide
Permalink
Thom May added a comment -

http://github.com/thommay/ohai/tree/OHAI-40

Show
Thom May added a comment - http://github.com/thommay/ohai/tree/OHAI-40
Hide
Permalink
Adam Jacob added a comment -

This is merged - thanks guys! You rock.

Show
Adam Jacob added a comment - This is merged - thanks guys! You rock.

People

  • Assignee:
    Adam Jacob
    Reporter:
    Bryan McLellan [Opscode]
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: