ohai throws stack when python is not in path

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.1.4
  • Fix Version/s: 0.2.0
  • Component/s: New Plugins
  • Labels:
    None
  • Environment:

    OpenBSD,

Description

the python plugin calls methods on a block scoped variable without checking to see if the variable has been defined. trace below

[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin os
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin ruby
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin languages
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin kernel
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin command
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin ec2
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin hostname
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin openbsd4.4::hostname
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin network
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin openbsd4.4::network
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin erlang
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin java
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin keys
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin ohai_time
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin platform
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin openbsd4.4::platform
[Tue, 24 Feb 2009 15:46:24 +0900] INFO: Loading plugin python
/home/msf/git/ohai/lib/ohai/plugins/python.rb:24:in `from_file': private method `split' called for nil:NilClass (NoMethodError)
from ./bin/../lib/ohai/mixin/command.rb:185:in `[]'
from ./bin/../lib/ohai/mixin/command.rb:185:in `popen4'
from /home/msf/git/ohai/lib/ohai/plugins/python.rb:22:in `from_file'
from ./bin/../lib/ohai/system.rb:117:in `require_plugin'
from ./bin/../lib/ohai/system.rb:112:in `each'
from ./bin/../lib/ohai/system.rb:112:in `require_plugin'
from ./bin/../lib/ohai/system.rb:99:in `all_plugins'
from ./bin/../lib/ohai/system.rb:92:in `each'
from ./bin/../lib/ohai/system.rb:92:in `all_plugins'
from ./bin/../lib/ohai/system.rb:90:in `each'
from ./bin/../lib/ohai/system.rb:90:in `all_plugins'
from bin/ohai:55

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mathieu Sauve-Frankel added a comment -

I made two commits for this issue in the OHAI-62 branch in my clone on github.
One patch is a simple fix for the reported issue. The other makes the python plugin
resemble java.rb in style.

Show
Mathieu Sauve-Frankel added a comment - I made two commits for this issue in the OHAI-62 branch in my clone on github. One patch is a simple fix for the reported issue. The other makes the python plugin resemble java.rb in style.
Hide
Permalink
Mathieu Sauve-Frankel added a comment -

The second patch causes one of the regress tests to fail. Fix in the works

Show
Mathieu Sauve-Frankel added a comment - The second patch causes one of the regress tests to fail. Fix in the works
Hide
Permalink
James Gartrell added a comment -

This is also fixed in git://github.com/jgartrel/ohai.git, OHAI-65, which should hopefully be integrated soon.

Show
James Gartrell added a comment - This is also fixed in git://github.com/jgartrel/ohai.git, OHAI-65 , which should hopefully be integrated soon.
Hide
Permalink
Adam Jacob added a comment -

This is fixed in head.

Show
Adam Jacob added a comment - This is fixed in head.

People

  • Assignee:
    Adam Jacob
    Reporter:
    Mathieu Sauve-Frankel
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: